Enforce right-hand-rule on PCA eigenvectors #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since eigenvectors can be interpreted as a vector space basis (i.e. a Rotation matrix) this commits enforce the behavior where the eigenvectors follow the right-hand rule and thus can be used directly as a rotation matrix/space vector basis. This PR addresses the issue pointed out in PointCloudLibrary#2879
|
Would you mind to add a sentence or two describing the new behavior to the documentation? |
taketwo
added
module: common
changelog: behavior change
SergioRAgostinho
approved these changes
Mar 27, 2019
|
@taketwo let me know if the documentation change is ok. I included the information stating that Eigenvector are stored as column vectors because, in my opinion, the ambiguity can create problems at developing time (as I experienced first hand). |
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since eigenvectors can be interpreted as a vector space basis (i.e. a Rotation matrix) this commits enforce the behavior where the eigenvectors follow the right-hand rule and thus can be used directly as a rotation matrix/space vector basis.
This PR addresses the issue pointed out in #2879