Refactor pcl::eigen33() to reduce potential errors (and remove bug)
#3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
force-pushed
the
eigen_refactor
branch
from
315d96e to
a98e206
Compare
taketwo
changed the title
pcl::eigen33() to reduce potential errors (and remove bug)
taketwo
reviewed
Oct 29, 2019
taketwo
approved these changes
Oct 30, 2019
kunaltyagi
force-pushed
the
eigen_refactor
branch
from
b921df0 to
675bedf
Compare
|
I've moved around the hunks between the commits for a more better history. PTAL (after CI gives the green) |
SergioRAgostinho
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through #3057 and found it hard to understand what was going on. So I refactored the code to become more legible and in the process, I inadvertently fixed the bug too.
The test cases are still in the other PR, and I haven't compiled either my changes or against the test cases yet....
Supercedes and closes #3057.