Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registration] Fix bug in NDT step interval convergence criteria #4181

Merged
merged 1 commit into from
Jun 23, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion registration/include/pcl/registration/impl/ndt.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ NormalDistributionsTransform<PointSource, PointTarget>::computeStepLengthMT (con
double g_u = auxilaryFunction_dPsiMT (d_phi_0, d_phi_0, mu);

// Check used to allow More-Thuente step length calculation to be skipped by making step_min == step_max
bool interval_converged = (step_max - step_min) > 0, open_interval = true;
bool interval_converged = (step_max - step_min) < 0, open_interval = true;

double a_t = step_init;
a_t = std::min (a_t, step_max);
Expand Down