[common] Switch int to index_t for field index variables in pclBase, add pcl::UNAVAILABLE for same
#4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
approved these changes
Jun 23, 2020
kunaltyagi
changed the title
int to index_t for field indec variables in pclBase, add pcl::UNAVAILABLE for same
kunaltyagi
added
needs: code review
kunaltyagi
reviewed
Jun 24, 2020
| @@ -237,7 +240,7 @@ namespace pcl | |||
| std::vector<int> field_sizes_; | |||
There was a problem hiding this comment.
Let's make another PR for this?
There was a problem hiding this comment.
Since this is explicitly used for sizes, and thus cannot be negative, do you suppose uindex_t would be better for this?
There was a problem hiding this comment.
I suppose so
PS: If this is wrong, then sergio or compilers will point it out to us 😆
There was a problem hiding this comment.
I'll go ask the compilers.
SergioRAgostinho
approved these changes
Jun 24, 2020
SergioRAgostinho
removed
the
needs: code review
kunaltyagi
changed the title
int to index_t for field indec variables in pclBase, add pcl::UNAVAILABLE for sameint to index_t for field index variables in pclBase, add pcl::UNAVAILABLE for same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.