[common] Modify index type for PCLPointField #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
reviewed
Jun 24, 2020
kunaltyagi
approved these changes
Jun 24, 2020
SergioRAgostinho
approved these changes
Jun 24, 2020
kunaltyagi
added a commit
that referenced
this pull request
Jun 25, 2020
This reverts commit ae87389.
|
Oops. Did a boo-boo. Realized after merging that this is an ABI break. @haritha-j Please open a new PR with the same contents and label it as such, with milestone PCL 1.12 |
koide3
pushed a commit
to koide3/pcl
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added @kunaltyagi's request from #4211 regarding switching
std::vector<int> field_sizes_;touindex_tto this PR, sincefield_sizes_refers to the size ofPCLPointField. If that's inappropriate, I'll move that to a seperate PR.