MLS: correct typo in principle by using principal instead

[keineahnung2345]

No description provided.

[mvieth]

It is problematic to just change the API. You could add a function with the old name that calls the function with the new, correct name, and add a deprecation notice.

[keineahnung2345]

Another question, the constant MLS_MINIMUM_PRINCIPAL_CURVATURE is mentioned in the comment, but I can't find it in the code, should I create this constant and replace the 1e-5 in calculatePrincipalCurvatures with it?

[mvieth]

Hm, the constant was added in this commit, but later removed in the same pull request, and only the mention in the documentation remained. I kinda agree with the review comments on the addition, so I would tend to just change the documentation.

[keineahnung2345]

@mvieth I've updated the doc.

[kunaltyagi]

Can we move the deprecated function to the declaration site? That would make it easier to remove in future

[keineahnung2345]

@kunaltyagi Sorry but what do you mean by "move to the declaration site"?

[kunaltyagi]

The simple definition of the deprecated function could be moved to the header (the function declaration) so removing it post deprecation is easier.

[mvieth]

Hm, now macOS fails because of the undefined inline function. Is there any other solution than to revert the last commit?

[keineahnung2345]

According to mpx/lua-cjson#28, one way is removing inline...

[mvieth]

You mean removing inline from calculatePrincipalCurvatures? Sure, let's give it a try.

[keineahnung2345]

@mvieth It works.