Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLS: correct typo in principle by using principal instead #4505

Merged
merged 13 commits into from
Feb 2, 2021
Merged

MLS: correct typo in principle by using principal instead #4505

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
270a0a1
MLS: principle > principal
keineahnung2345 Nov 10, 2020
ec5e801
principle -> principal in mls.hpp
keineahnung2345 Nov 10, 2020
f331221
calculatePrincipleCurvatures calls calculatePrincipalCurvatures
keineahnung2345 Nov 11, 2020
bc4cbaa
deprecation message
keineahnung2345 Nov 11, 2020
4388973
follow deprecation policy
keineahnung2345 Nov 12, 2020
1fe61c1
Merge branch 'master' into mls_principal
keineahnung2345 Nov 12, 2020
e4f5bf5
update doc
keineahnung2345 Nov 30, 2020
b3a575a
update doc
keineahnung2345 Dec 1, 2020
3801ee9
principal
keineahnung2345 Dec 1, 2020
e546181
Correct version for removal in 2 releases after 1.12
kunaltyagi Dec 5, 2020
3b3ae4c
Merge branch 'master' into mls_principal
keineahnung2345 Dec 14, 2020
db3b85a
Move deprecated function's definition to .h file
keineahnung2345 Dec 14, 2020
3cc8e18
remove "inline"
keineahnung2345 Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions surface/include/pcl/surface/impl/mls.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ pcl::MLSResult::getPolynomialPartialDerivative (const double u, const double v)
}

Eigen::Vector2f
pcl::MLSResult::calculatePrincipleCurvatures (const double u, const double v) const
pcl::MLSResult::calculatePrincipalCurvatures (const double u, const double v) const
{
Eigen::Vector2f k (1e-5, 1e-5);

Expand All @@ -559,12 +559,18 @@ pcl::MLSResult::calculatePrincipleCurvatures (const double u, const double v) co
}
else
{
PCL_ERROR ("No Polynomial fit data, unable to calculate the principle curvatures!\n");
PCL_ERROR ("No Polynomial fit data, unable to calculate the principal curvatures!\n");
}

return (k);
}

Eigen::Vector2f
pcl::MLSResult::calculatePrincipleCurvatures (const double u, const double v) const
{
return calculatePrincipalCurvatures(u, v);
}

pcl::MLSResult::MLSProjectionResults
pcl::MLSResult::projectPointOrthogonalToPolynomialSurface (const double u, const double v, const double w) const
{
Expand Down
12 changes: 11 additions & 1 deletion surface/include/pcl/surface/mls.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,23 @@ namespace pcl
inline PolynomialPartialDerivative
getPolynomialPartialDerivative (const double u, const double v) const;

/** \brief Calculate the principle curvatures using the polynomial surface.
/** \brief Calculate the principal curvatures using the polynomial surface.
* \param[in] u The u-coordinate of the point in local MLS frame.
* \param[in] v The v-coordinate of the point in local MLS frame.
* \return The principle curvature [k1, k2] at the provided uv coordinates.
* \note If an error occurs the MLS_MINIMUM_PRINCIPLE_CURVATURE is returned.
mvieth marked this conversation as resolved.
Show resolved Hide resolved
*/
inline Eigen::Vector2f
calculatePrincipalCurvatures (const double u, const double v) const;

/** \brief Calculate the principal curvatures using the polynomial surface.
* \param[in] u The u-coordinate of the point in local MLS frame.
* \param[in] v The v-coordinate of the point in local MLS frame.
* \return The principal curvature [k1, k2] at the provided ub coordinates.
* \note If an error occurs then 1e-5 is returned.
*/
PCL_DEPRECATED(1, 14, "use calculatePrincipalCurvatures() instead")
kunaltyagi marked this conversation as resolved.
Show resolved Hide resolved
inline Eigen::Vector2f
calculatePrincipleCurvatures (const double u, const double v) const;

/** \brief Project a point orthogonal to the polynomial surface.
Expand Down