Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config has no split attribute for Item_filter #599

Closed
fredrik-hellmangroup opened this issue Jul 24, 2016 · 5 comments
Closed

Config has no split attribute for Item_filter #599

fredrik-hellmangroup opened this issue Jul 24, 2016 · 5 comments
Labels

Comments

@fredrik-hellmangroup
Copy link
Contributor

Expected Behavior

Split and read the string to array?

Actual Behavior

D:\Pokemon stuff\PokemonGo-Bot>pokecli.py
Traceback (most recent call last):
File "D:\Pokemon stuff\PokemonGo-Bot\pokecli.py", line 219, in
main()
File "D:\Pokemon stuff\PokemonGo-Bot\pokecli.py", line 196, in main
config = init_config()
File "D:\Pokemon stuff\PokemonGo-Bot\pokecli.py", line 168, in init_config
config.item_filter = [str(item_id) for item_id in config.item_filter.split(',')]
AttributeError: 'list' object has no attribute 'split'

Steps to Reproduce

Have up-to-date config.json

Other Information

OS: Win10 pro x64
Git Commit: a634b55

fredrik-hellmangroup referenced this issue Jul 24, 2016
* Fix issue -if not working properly #517

* Modify README.md & Fix config.json.example

* Add my self to contrib list in README.md
@fsegouin
Copy link
Contributor

Same error here.

@Balauue
Copy link

Balauue commented Jul 24, 2016

Had the same issue, because the notation has changed. Now I use "101,102,103" as opposed to ["101","102","103"], which worked 12 hours ago

@fredrik-hellmangroup
Copy link
Contributor Author

Seems to be working

@dmateusp
Copy link
Contributor

Please don't mark it as working! the logic hasn't be changed by the person that "fixed" the problem, a list should be used because I use "101" in list, I'm working on making both "101,102,103" and ["101","102","103"] work but it will drop everything at the moment !

@fredrik-hellmangroup
Copy link
Contributor Author

@dmadisetti assign the issue to yourself then please :)

hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this issue Sep 28, 2016
* Add Dockerfile

* Update Dockerfile to use Alpine Python base image

* Remove unnecessary mkdir

* Add basic usage information

* Delete apk package cache after installing packages, to shrink the image size

* Use --no-cache with apk add to remove the need to delete the cache afterwards

* Combined installing packages with running pip to allow us to remove packages and shrink the image

* Install ca-certificates package earlier so it's not invalidated by python deps changes

* Add .dockerignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants