Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine which ball to use base on catch rate % #618

Merged
merged 11 commits into from
Jul 24, 2016
Merged

Conversation

earthchie
Copy link
Contributor

change to better ball type if catch rate is fall under 35%

image

Minor changes

  • display catch rate %
  • add [] to color log

@fredrik-hellmangroup
Copy link
Contributor

great pull request

@eggins
Copy link
Contributor

eggins commented Jul 24, 2016

this is the kind of request we need!

@eggins eggins merged commit 819fd33 into PokemonGoF:dev Jul 24, 2016
@eggins
Copy link
Contributor

eggins commented Jul 24, 2016

Uh-oh. You broke something.

@fredrik-hellmangroup
Copy link
Contributor

@eggins dont think he did, i copied over the content locally without issues, commit a634b55 did -> #599

@Shoh
Copy link
Contributor

Shoh commented Jul 24, 2016

Thank you for wiping out my changes... I don't mind the catch % but I would have preferred if you kept my logic to not use great balls or ultra balls if your stock is less than 10.

@earthchie
Copy link
Contributor Author

@Shoh Sorry about that. Dont' worry some one made new PR about this already. #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants