Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API update fixes (i2f etc) and lured pokemon catching #1082

Closed
wants to merge 1 commit into from
Closed

API update fixes (i2f etc) and lured pokemon catching #1082

wants to merge 1 commit into from

Conversation

glennvgastel
Copy link
Contributor

@glennvgastel glennvgastel commented Jul 27, 2016

Short Description:

Allows us to use the new API version. Fixed i2f functions, geocoding and various method/property name changes.
Also adds catching lured pokemon again.

Fixes:

  • Errors related to new tejado pgoapi version
  • Pokemon spawning from lures will now be caught
  • Geocoding issue with i2f has been resolved

@glennvgastel
Copy link
Contributor Author

Tested for 20 mins, runs without errors.

pokemongobot-1082 exe

@OVO647
Copy link

OVO647 commented Jul 27, 2016

How do I get this to run properly with lure catching?

@glennvgastel
Copy link
Contributor Author

@OVO647 Pull my branch, then run pip install --upgrade -r requirements.txt

@OVO647
Copy link

OVO647 commented Jul 27, 2016

Ok I'm running it now and I get this error.

Traceback (most recent call last):
File "pokecli.py", line 220, in
main()
File "pokecli.py", line 211, in main
bot.take_step()
File "/Users/User/Desktop/PokemonGo-Bot/pokemongo_bot/init.py", line 36, in take_step
self.stepper.take_step()
File "/Users/User/Desktop/PokemonGo-Bot/pokemongo_bot/stepper.py", line 62, in take_step
self._work_at_position(position[0], position[1], position[2], True)
File "/Users/User/Desktop/PokemonGo-Bot/pokemongo_bot/stepper.py", line 139, in _work_at_position
self.bot.work_on_cell(cell, position, pokemon_only)
File "/Users/User/Desktop/PokemonGo-Bot/pokemongo_bot/init.py", line 92, in work_on_cell
worker = MoveToFortWorker(fort, self)
File "/Users/User/Desktop/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_fort_worker.py", line 11, in init
self.navigator = bot.navigator
AttributeError: 'PokemonGoBot' object has no attribute 'navigator'

@rhysd
Copy link
Contributor

rhysd commented Jul 27, 2016

Currently 'pgoapi' package commit hash is fixed to avoid the errros. Please ensure to also update the commit hash in requirements.txt to use the latest pgoapi package.

@solderzzc
Copy link
Contributor

Thanks @rhysd , let me close this issue.

@solderzzc solderzzc closed this Jul 27, 2016
@rhysd
Copy link
Contributor

rhysd commented Jul 27, 2016

@solderzzc

My fix in #1117 is just a way to 'avoid' breaking this bot immediately when protobuf definition in pgoapi is updated. Apart from it, IMO, we also need to follow the update of pgoapi because remote Pokémon Go APIs will be updated.

@rhysd
Copy link
Contributor

rhysd commented Jul 27, 2016

@solderzzc

Could you tell me why this PR is closed? I think this fix is needed to follow up 'pgoapi' package update.

@glennvgastel
Copy link
Contributor Author

@rhysd @solderzzc Rebased and reopened here : #1163
Needless to say, it's the last time I'll try merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants