Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pgoapi package repository hash #1117

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jul 27, 2016

Short Description:

Fix 'pgoapi' package repository hash because latest one broke this bot. It seems that protobuf definition was updated. I think it is better that update pgoapi version with confirming manually.

Fixes:

  • Fixed pgoapi package's commit hash to the one with which at least I confirmed this bot worked well.

@eggins
Copy link
Contributor

eggins commented Jul 27, 2016

👍

Approved with PullApprove

@eggins
Copy link
Contributor

eggins commented Jul 27, 2016

There is a build error.
--editable=git+https://github.com/tejado/pgoapi.git@3787ffbe2e80ebce8a02d48eebceb9edf40179c1 is not the right format; it must have #egg=Package
The command "pip install -r requirements.txt" failed and exited with 1 during .

because latest one breaks this bot
@rhysd
Copy link
Contributor Author

rhysd commented Jul 27, 2016

@eggins

Ah, sorry, I forgot to add #egg=. I fixed in a397e3c

@solderzzc
Copy link
Contributor

solderzzc commented Jul 27, 2016

👍

Approved with PullApprove

@elicwhite elicwhite merged commit 9ea015e into PokemonGoF:master Jul 27, 2016
@rhysd rhysd deleted the fix-pgoapi-version branch July 27, 2016 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants