Clean logging option #3706
Clean logging option #3706
Conversation
ghost
mentioned this pull request
|
Thank you! |
| {"location": "Bialik 150, Ramat Gan"}, | ||
| {"location": "Ayalon Highway, Ramat Gan"}, | ||
| {"location": "32.091280, 34.795261"} | ||
| ] |
There was a problem hiding this comment.
I really do not know, but I added the file again
|
@douglascamata Please review this |
|
@extink you only updated the coloured logging handler, please update the normal one too. Also, please, make a nested configuration for logs, something like: Take a look at the |
|
@douglascamata, done! |
|
Any idea when this will be merged with the dev? It's pretty low risk as all it's doing is cleaning up the output log. |
|
I think your merge was messed up. This PR now has 33 changes files with TONS of changes. Was this intended? |
|
Nope, that was not intended. Cleaned up the commits on this PR. Should be correct now. If not, let me hear! |
| logging.getLogger("rpc_api").setLevel(log_level) | ||
|
|
||
| if self.config.logging_clean and not self.config.debug: | ||
| formatter = Formatter(fmt='[%(asctime)s] %(message)s', datefmt='%H:%M:%S') |
There was a problem hiding this comment.
@extink Do you think it could be possible to have the choice of what to show in the settings ? I like seeing the name, but I totally understand that’s superfluous to most user. Having the choice with this setting by default seems a good compromise to me.
There was a problem hiding this comment.
@BriceSD I think you tagged me by mistake, but I would also like a choice if possible.
This is very clustered for me.
2016-08-13 14:07:53,999 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Tentacool appeared! [CP 308] [Potential 0.6] [A/D/S 10/2/15]
This is a million times better
2016-08-13 14:07 [pokemon_appeared] A wild Tentacool appeared! [CP 308] [Potential 0.6] [A/D/S 10/2/15]
Also, not sure if its the code or my terminal but if the date could be changed to 08-13-2016 (MM/DD/YYYY) and the time to 12 hour format I would be really happy. I know that USA is probably the only ones that use this date/time format.
|
Is this PR dead or alive? |
|
@extink what is the delay in this? will this EVER be approved for merge? |
|
@douglascamata: I was waiting for a respone from you guys after my last commit. I had asked if everything was as you guys wished for. If I need to add anything I would like to hear what! |
|
@extink am I not a guy ? :< |
|
@BriceSD, did not know you were one of the 'guys'. But if you would like that implemented, I can do that for you ;) |
|
@extink merge conflicts again |
|
@extink any update?? |
|
@nanogirl21 waiting on devs to merge @douglascamata @TheSavior @BriceSD ping - PR ready for review |
|
Since this one is logging stuff, I defer to @douglascamata. |
|
@TheSavior & @douglascamata hope you guys can review this one |
|
close since no activity in 13days/ |
|
Ehm, why? I have rebased this pr almost every day for the merge... |
|
That is batshit insane! |
|
@solderzzc ? |
|
@k4n30 need manually fix the conflict. hmm. . |
|
I think it's that the rebases weren't showing up, so it looked like it was dead. |
|
If there is still issues, I'll try and help make a clean pull request for this. Hopefully with your name on it all later tonight aest time |
|
And again, rebased the branch ;) |
|
I'll wait for CI check then merge. Sorry about the delay @extink |
|
CI passed. Merging! Thanks for the PR, again sorry it took so long to merge. |
|
@mjmadsen the rebase wil not usually show up, because it only rebases the current commits, without changing the timestamps. But thanks for the merge! |
|
@extink I think that's why he closed it. Looked like it hadn't been touched in quite a few days. Again, sorry for the delay. |
Short Description:
Adds an option to enable clean logging. This will strip all meta data from the logging messages like the name of the process, the name of the event, etc.
Fixes