-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable simple log output #4821
enable simple log output #4821
Conversation
@rawgni, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @mjmadsen to be potential reviewers |
This should work... ish, but I'm not a fan of this approach as it's putting logger logic into the main bot client and it should be kept separate. Additionally, it requires a command line switch (should be in config). Suggest adding something appropriate to config, and setting the logging options in the logger class (both logging_handler and colored_logging_handler) initialization, eg.
|
We finally merged #3706. I think it does a similar function. I'll leave up until further review. |
@mjmadsen Similar, but doesn't appear to strip date/time, just the "extra" info (process name etc.) Needs another config option to strip d/t? |
@Gobberwart good eye. It would be nice if we could add to #3706 on which parts we want to see (each a separate config var). |
@mjmadsen Something like that. Maybe something in config like:
|
@Gobberwart Yeah, that'd be perfect. |
I think PR #4832 can replace this as it provides even more options in a cleaner way. |
close in favour of #4832 |
Short Description:
add -sl / --simplelog to pokecli.py
Fixes/Resolves/Closes (please use correct syntax):
- #4800