Split max_distance into max_sniping_distance and max_walking_distance #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jasperrr91, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mhdasding, @DBa2016 and @chrisle to be potential reviewers |
| "//NOTE: Change the max_sniping_distance to adjust the max sniping range (m)": {}, | ||
| "max_sniping distance": 10000, | ||
| "//NOTE: Change the max_walking_distance to adjust the max walking range when snipe is off (m)": {}, | ||
| "max__walking_distance": 500, |
There was a problem hiding this comment.
Ahh it was late, sorry.
|
👍 |
|
We need to throw a warning that max_distance is depreciated. Lots of folks not updating their config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Split max_distance into max_sniping_distance and max_walking_distance
Fixes/Resolves/Closes (please use correct syntax):