-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split max_distance into max_sniping_distance and max_walking_distance #4978
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -612,7 +612,8 @@ This task will fetch current pokemon spawns from /raw_data of an PokemonGo-Map i | |
* `prioritize_vips` - Will prioritize vips in distance and priority mode above all normal pokemon if set to true | ||
* `min_time` - Minimum time the pokemon has to be available before despawn | ||
* `min_ball` - Minimum amount of balls required to run task | ||
* `max_distance` - Maximum distance the pokemon is allowed to be when sniping. (km) | ||
* `max_sniping_distance` - Maximum distance the pokemon is allowed to be caught when sniping. (m) | ||
* `max_walking_distance` - Maximum distance the pokemon is allowed to be caught when sniping is turned off. (m) | ||
* `snipe`: | ||
- `True` - Will teleport to target pokemon, encounter it, teleport back then catch it | ||
- `False` - Will walk normally to the pokemon | ||
|
@@ -634,8 +635,10 @@ This task will fetch current pokemon spawns from /raw_data of an PokemonGo-Map i | |
"type": "MoveToMapPokemon", | ||
"config": { | ||
"address": "http://localhost:5000", | ||
"//NOTE: Change the max_distance to adjust the max sniping range (km)": {}, | ||
"max_distance": 500, | ||
"//NOTE: Change the max_sniping_distance to adjust the max sniping range (m)": {}, | ||
"max_sniping distance": 10000, | ||
"//NOTE: Change the max_walking_distance to adjust the max walking range when snipe is off (m)": {}, | ||
"max__walking_distance": 500, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo here... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahh it was late, sorry. |
||
"min_time": 60, | ||
"min_ball": 50, | ||
"prioritize_vips": true, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that better to use
km
in sniper distance?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think that's much more readable. I'll add that.