Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat decoupled from tasks. #5243

Merged
merged 10 commits into from
Sep 7, 2016
Merged

Heartbeat decoupled from tasks. #5243

merged 10 commits into from
Sep 7, 2016

Conversation

sohje
Copy link
Contributor

@sohje sohje commented Sep 6, 2016

Short Description:

Heartbeats decoupled from tasks. Heartbeat coupled to bot main instance, separate main hb logic from any tasks.

Fixes/Resolves/Closes (please use correct syntax):

  • Need some additional tests, works for me (evolved 40 pokemons, heartbeats is ok)
  • No need Fix #5232 #5237

@solderzzc
Copy link
Contributor

Need a ignore heartbeat flag, since sniper will change location but should not send heartbeat since the location changed. correct me if I'm wrong.

@sohje
Copy link
Contributor Author

sohje commented Sep 6, 2016

@solderzzc Ops, sure! Add a flag to bot instance:

self.hb_locked = False

@julienlavergne
Copy link
Contributor

Is there any location info in the heartbeat ?

@solderzzc
Copy link
Contributor

solderzzc commented Sep 6, 2016

@anakin5 every api request contain auth info header, including device_info/location/sensor data.

@julienlavergne
Copy link
Contributor

ok. Also the heartbeat function update the timeout_fort list. Do we plan to move that somewhere else ? maybe in the tick ?

@rawgni
Copy link
Contributor

rawgni commented Sep 6, 2016

any idea what other APIs are being chained inside the heartbeat call ?
#4605

@solderzzc
Copy link
Contributor

solderzzc commented Sep 7, 2016

👍
Merge at the time, I believe the get_map_obj is in the heartbeat call as well.

Approved with PullApprove

@solderzzc solderzzc merged commit 01d965a into PokemonGoF:dev Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants