Decouple hb from step walker

[sohje]

Short Description:

Decouple hb from step walker due to #5243

Fixes/Resolves/Closes (please use correct syntax):

• Fix

[mention-bot]

@sohje, thanks for your PR! By analyzing the annotation information on this pull request, we identified @anakin5, @mjmadsen and @alexyaoyang to be potential reviewers

[th3w4y]

@sohje what is calling heartbeat now?

[sohje]

@th3w4y Heartbeat works in separate thread now, with timer and another checks, like block hb from sniping.

[th3w4y]

@sohje That part i noticed, what is did not noticed yet is when is this called except .login()

Heartbeat works in separate thread now, with timer and another checks, like block hb from sniping.

[sohje]

@th3w4y

threading.Timer(self.heartbeat_threshold, self.heartbeat).start()

[th3w4y]

@sohje This is amazing 💯 %

so it is actually this change [when the threading.Timer(self.heartbeat_threshold, self.heartbeat).start()was introduced] that made the bot walk faster not our StepWalker PolylineWalker! and NOW the speeds match the reality! #5172 👍

[sohje]

@th3w4y How can this be possible? We sending requests as usual.
upd. sorry, was sleepy i thoughts you were talking about bad decision to move hb to scheduled thread 😆

[th3w4y]

@sohje but that is a good thing that we can respect the speed settings...

Because is done in parallel walking does not need to wait after heartbeat....

@th3w4y How can this be possible? We sending requests as usual.

[th3w4y]

@sohje Looks perfect to me

like I was saying previous comments this actually fixes a real bug
(a new thread would have been spawn on every bot.tick())

[solderzzc]

👍