Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon Optimizer Improvements: buddy, evolve to final, evolve for xp #5478

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Conversation

julienlavergne
Copy link
Contributor

@julienlavergne julienlavergne commented Sep 16, 2016

@solderzzc
Copy link
Contributor

Are you sure we want to use new feature on old API version?

@julienlavergne
Copy link
Contributor Author

I guess we have to use the most recent version of the API .

@julienlavergne julienlavergne changed the title Add buddy selection in Pokemon Optimizer Pokemon Optimizer Improvements: buddy, evolve to final, evolve for xp Sep 17, 2016
@DeXtroTip
Copy link
Contributor

It's also needed to add the buddy distance for each pokemon at pokemon.json. I've already done that and can give it to you.
I'm working on a buddy task too and I might still make a PR since not everyone uses PokemonOptimizer, I think.

@solderzzc
Copy link
Contributor

PokemonOptimizer is my main pokemon maintain task, it's very helpful.

@julienlavergne
Copy link
Contributor Author

I added the distances in the file. Cannot see it in the review because too big but it's there.

@solderzzc
Copy link
Contributor

solderzzc commented Sep 18, 2016

👍 The feature list is really good. Haven't go deeply into the code.

Approved with PullApprove

@YvesHenri
Copy link

I dont use optimizer. Too lazy to set it up and the last and only time I did, it released all my 7 100% snorlaxes rofl

Add evolve_to_final and improve evolve_for_xp.
Rescale upgrade levels.
Remove 2% rule.
@julienlavergne
Copy link
Contributor Author

Anyone to approve ?

@solderzzc
Copy link
Contributor

solderzzc commented Sep 20, 2016

👍

Approved with PullApprove

@julienlavergne julienlavergne merged commit d1e983f into PokemonGoF:dev Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants