pokecli.py: wait_time for every exception randomized

[mudmud2k]

Feature Request (#5579)

Short Description:
it's create a random waiting time based on config for all exception (connection lost, throttling, and so on), so no static time span will be used anymore

---

randint(min,max)
config.reconnecting -> min
config.reconnection * 60 -> max

[mention-bot]

@mudmud2k, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @Gobberwart and @douglascamata to be potential reviewers

[solderzzc]

👍

[YvesHenri]

Can't review now. Someone please do it and merge, if agreed.

[DBa2016]

I think this needs adjustment and docs changes: previously, config.reconnecting_timeout was "time in minutes". Now the wait_time spans from this valud to the 60-times of it.

Maybe randint(config.reconnecting_timeout*60, (config.reconnecting_timeout + 1) * 60)) ?

[mudmud2k]

an other possibility is to extend the config file with min and max entries, which I think is a overkill for that.

maybe only an random variation of the given time, something like 'randint((config.reconnecting_timeout * 0.8 * 60, config.reconnecting_timeout * 1.2 * 60))'
40% vast/span/range...

also, I don't find any documentation about it, but I thought that I saw an entry once.

[DBa2016]

should be removed

[BreezeRo]

Any updates on this?

[mudmud2k]

still waiting for a review, or further discussion...

but without a working api, there is no need for it..

Changed as requesting

[solderzzc]

👍

[Gobberwart]

This doesn't work as expected...

wait_time = randint((config.reconnecting_timeout * 0.8 * 60), (config.reconnecting_timeout * 1.2 * 60))

randint requires two INTEGER values, whereas this line provides two FLOATS. Result:

Traceback (most recent call last):
  File ".\pokecli.py", line 844, in <module>
    main()
  File ".\pokecli.py", line 189, in main
    wait_time = randint((config.reconnecting_timeout * 0.8 * 60), (config.reconnecting_timeout *  1.2 * 60))
  File "C:\Python27\lib\random.py", line 242, in randint
    return self.randrange(a, b+1)
  File "C:\Python27\lib\random.py", line 187, in randrange
    raise ValueError, "non-integer arg 1 for randrange()"
ValueError: non-integer arg 1 for randrange()

[Gobberwart]

Correction: works if reconnecting_timeout in config is set to default 15, or any multiple of 5, but fails if set to anything else. (5 x 0.8 = 12 (int), 5 x 1.2 = 18 (int). In my case, I have reconnecting_timeout set to 3, so 3 x 0.8 = 2.4 (float), 3 x 1.2 = 3.6 (float).