-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pokecli.py: wait_time for every exception randomized #5704
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,7 @@ | |
import subprocess | ||
|
||
from logging import Formatter | ||
from random import randint | ||
|
||
codecs.register(lambda name: codecs.lookup("utf-8") if name == "cp65001" else None) | ||
|
||
|
@@ -185,7 +186,7 @@ def get_commit_hash(): | |
finished = False | ||
|
||
while not finished: | ||
wait_time = config.reconnecting_timeout * 60 | ||
wait_time = randint(config.reconnecting_timeout, (config.reconnecting_timeout * 60)) | ||
try: | ||
bot = initialize(config) | ||
bot = start_bot(bot, config) | ||
|
@@ -241,9 +242,10 @@ def get_commit_hash(): | |
'api_error', | ||
sender=bot, | ||
level='info', | ||
formatted='Server is throttling, reconnecting in 30 seconds' | ||
formatted='Server is throttling, reconnecting in {:d} seconds'.format(wait_time) | ||
) | ||
time.sleep(30) | ||
time.sleep(wait_time) | ||
# sys.exit() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be removed |
||
except PermaBannedException: | ||
bot.event_manager.emit( | ||
'api_error', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs adjustment and docs changes: previously, config.reconnecting_timeout was "time in minutes". Now the wait_time spans from this valud to the 60-times of it.
Maybe
randint(config.reconnecting_timeout*60, (config.reconnecting_timeout + 1) * 60))
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an other possibility is to extend the config file with min and max entries, which I think is a overkill for that.
maybe only an random variation of the given time, something like 'randint((config.reconnecting_timeout * 0.8 * 60, config.reconnecting_timeout * 1.2 * 60))'
40% vast/span/range...
also, I don't find any documentation about it, but I thought that I saw an entry once.