-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ Rework benchmarks #374
Merged
Merged
🛠️ Rework benchmarks #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2024
Merged
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
JuaniRios
force-pushed
the
08-06-new_tests
branch
from
August 7, 2024 09:33
c255378
to
6ee3f03
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
5 times, most recently
from
August 8, 2024 12:08
96311f9
to
3ba99a9
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
2 times, most recently
from
August 8, 2024 14:18
a02d194
to
70b4f51
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 9, 2024 10:14
70b4f51
to
92d936a
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 9, 2024 11:19
92d936a
to
159843f
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 9, 2024 11:36
159843f
to
8e068a8
Compare
JuaniRios
changed the base branch from
08-06-new_tests
to
08-09-remove_auctioninitializeperiod
August 9, 2024 11:36
JuaniRios
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 9, 2024 11:41
275751b
to
8def483
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
2 times, most recently
from
August 9, 2024 11:51
3786682
to
4215056
Compare
JuaniRios
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 13, 2024 09:04
8def483
to
aa77143
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 13, 2024 09:05
4215056
to
098b767
Compare
JuaniRios
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 13, 2024 09:27
aa77143
to
deac748
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 13, 2024 09:27
098b767
to
e664a08
Compare
JuaniRios
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 13, 2024 09:39
deac748
to
44ce271
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 13, 2024 09:39
e664a08
to
568dfc0
Compare
This was referenced Aug 13, 2024
Closed
lrazovic
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 16, 2024 13:04
44ce271
to
7b4f8cd
Compare
lrazovic
force-pushed
the
08-07-fix_benchmarks
branch
from
August 16, 2024 13:04
568dfc0
to
4b894f9
Compare
Closed
JuaniRios
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 16, 2024 13:10
7b4f8cd
to
44ce271
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 16, 2024 13:10
4b894f9
to
568dfc0
Compare
lrazovic
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 16, 2024 13:14
44ce271
to
7b4f8cd
Compare
lrazovic
force-pushed
the
08-07-fix_benchmarks
branch
from
August 16, 2024 13:14
568dfc0
to
4b894f9
Compare
vstam1
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see a net code removal of 1300 lines in the benchmarks! Left a couple of comments
JuaniRios
force-pushed
the
08-09-remove_auctioninitializeperiod
branch
from
August 22, 2024 12:57
7b4f8cd
to
e26d80c
Compare
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 22, 2024 12:57
4b894f9
to
c63f773
Compare
vstam1
approved these changes
Aug 23, 2024
Merge activity
|
JuaniRios
changed the base branch from
08-09-remove_auctioninitializeperiod
to
graphite-base/374
August 23, 2024 10:41
JuaniRios
force-pushed
the
08-07-fix_benchmarks
branch
from
August 23, 2024 10:46
c63f773
to
66a31b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing?
cargo test --features runtime-benchmarks
just dry-run-benchmarks
Keep in mind you need to do a cargo clean for it to work (dunno why)
Anything Else?
Had to delete the runtime weights since the weight struct looks different. The runtime now uses the default
()
from the new weight file I generated in the pallet.Soon we will generate the real pallet/runtime benchmarks in AWS