Use native Node promisify, to aviod issues with Node 10 #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: #496 |
|
I'd definitely go with the native option, especially considering |
|
This is pretty great! Thanks, @HitkoDev -- I'm currently working on Node 10-ifying the tools suite and I really appreciate this PR. |
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 8 comes with a builtin promisify function, which has proper type declarations and is well-tested.
promisify-nodebreaks with Node 10, since we don't need support for Node < 8, we should use the builtin function.tools/package.json
Line 29 in ec5693d