2.0 preview #113
2.0 preview #113
Conversation
valdrinkoshi
force-pushed
the
2.0-preview
branch
2 times, most recently
from
57650d9 to
7764400
Compare
valdrinkoshi
force-pushed
the
2.0-preview
branch
from
7764400 to
db47c20
Compare
valdrinkoshi
force-pushed
the
2.0-preview
branch
3 times, most recently
from
b7b7680 to
092aaf4
Compare
valdrinkoshi
force-pushed
the
2.0-preview
branch
from
b8299c7 to
77e809e
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
2.0-preview updates to travis.yaml, bower.json, and more
valdrinkoshi
force-pushed
the
2.0-preview
branch
from
4558d9d to
b6a1da6
Compare
iron-dropdown-scroll-manager.html
Outdated
| document.addEventListener('DOMMouseScroll', this._boundScrollHandler, { | ||
| capture: true, | ||
| passive: false | ||
| }); |
There was a problem hiding this comment.
MDN claims IE and Edge don't support objects as the third argument to addEventListener; do these work as expected? Maybe they're coerced to booleans?
There was a problem hiding this comment.
Exactly, I've added a note regarding this 👌
Change Travis to Chrome beta
demo/x-select.html
Outdated
| </div> | ||
| <iron-dropdown id="dropdown" | ||
| vertical-align="[[verticalAlign]]" | ||
| horizontal-align="[[horizontalAlign]]" | ||
| disabled="[[disabled]]" | ||
| open-animation-config="[[openAnimationConfig]]" | ||
| close-animation-config="[[closeAnimationConfig]]"> | ||
| <content select=".dropdown-content"></content> | ||
| <slot></slot> |
There was a problem hiding this comment.
(Discussion in paper-menu-button for reference: https://github.com/PolymerElements/paper-menu-button/pull/105/files#r109993878)
I think we should convert this to a named slot like dropdown-trigger.
There was a problem hiding this comment.
I saw this as an occasion to update iron-dropdown to be less selective, but since that could be seen as a breaking change (e.g. this example) it's probably best to keep that strict selectiveness via a named slot. Will update
iron-dropdown.html
Outdated
| overflow: hidden; | ||
| } | ||
| </style> | ||
|
|
||
| <div id="contentWrapper"> | ||
| <content id="content" select=".dropdown-content"></content> | ||
| <slot id="content"></slot> |
There was a problem hiding this comment.
This should be a named slot also.
README.md
Outdated
| @@ -20,7 +20,7 @@ _[Demo and API docs](https://elements.polymer-project.org/elements/iron-dropdown | |||
| ##<iron-dropdown> | |||
There was a problem hiding this comment.
I think a space after ## might make this render properly?
iron-dropdown.html
Outdated
| </iron-dropdown> | ||
|
|
||
| In the above example, the `<div>` with class `.dropdown-content` will be | ||
| In the above example, the `<div>` with slot `dropdown-content` will be |
There was a problem hiding this comment.
'with slot dropdown-content' -> 'assigned to the dropdown-content slot' ?
* Consistent use of CamelCase in bower dependencies * made the "variants 1.x" section consistent as well
Relevant updates:
demo-snippeton demo page, add dev-dependency onweb-animations-jsasneon-animationdoesn't anymorecomposedin the unit tests_focusTargetpassive: falseas in Canarytouchstart, touchmovelisteners treat the target as passive by default https://bugs.chromium.org/p/chromium/issues/detail?id=652519