Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

2.0 preview #113

Merged
merged 34 commits into from
May 13, 2017
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
151e86a
port to 2.0
valdrinkoshi Aug 27, 2016
4582768
update repos links
valdrinkoshi Sep 8, 2016
34089da
update deps
valdrinkoshi Sep 12, 2016
4cb575a
use only slot
valdrinkoshi Sep 28, 2016
f1ce761
webanimations as devDep
valdrinkoshi Oct 4, 2016
44348d0
more descriptive tests. Make passive: false explicit.
valdrinkoshi Oct 4, 2016
a520a67
use variants
valdrinkoshi Dec 8, 2016
92c43a3
revert type for animation configs
valdrinkoshi Dec 8, 2016
0633279
revert setting of sizingTarget, should be done in attached
valdrinkoshi Dec 9, 2016
c794f95
remove not used animation
valdrinkoshi Dec 9, 2016
c2572ac
use neon-animation 2.0-preview also in the 1.x variant
valdrinkoshi Dec 9, 2016
65a90a9
use neon-animation/web-animations.html
valdrinkoshi Dec 9, 2016
c9cb531
resolutions
valdrinkoshi Dec 9, 2016
77e809e
update deps and resolutions
valdrinkoshi Dec 10, 2016
6a49cc0
Depend on test-fixture v2
tedium-bot Jan 12, 2017
9feb921
Merge pull request #122 from PolymerElements/auto-test-fixture
e111077 Jan 12, 2017
9a269ed
auto-generated: update repo for v2
tedium-bot Jan 25, 2017
04489eb
Merge pull request #123 from PolymerElements/_auto_generated_v2_preview
notwaldorf Jan 25, 2017
c3f5545
remove flush as shadydom#56 got fixed
valdrinkoshi Feb 24, 2017
b6a1da6
update deps
valdrinkoshi Feb 28, 2017
3ead135
update deps
valdrinkoshi Mar 1, 2017
4e82440
Point to Polymer 2.0 RC 1
tedium-bot Mar 7, 2017
ac3bcc9
Update travis config
tedium-bot Apr 7, 2017
a97c906
Merge pull request #130 from PolymerElements/auto-cleanup
e111077 Apr 7, 2017
d183969
Keep list of scroll events
valdrinkoshi Apr 10, 2017
6b2bbb9
named slot
valdrinkoshi Apr 10, 2017
8c30317
use only slots
valdrinkoshi Apr 10, 2017
d1c661c
[skip ci] assigned to the slot
valdrinkoshi Apr 10, 2017
874f5ba
Merge branch 'master' into 2.0-preview
valdrinkoshi Apr 18, 2017
af58c46
remove test-fixture dependency
valdrinkoshi Apr 19, 2017
0e06557
update readme
valdrinkoshi Apr 19, 2017
0314482
query for content and slot, skip non-elements
valdrinkoshi Apr 19, 2017
0b83a0f
Update travis config (#136)
e111077 May 12, 2017
9531ee0
from polymerelements to PolymerElements in 2.0-preview (#133)
bartolom May 12, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
language: node_js
sudo: required
before_script:
- npm install -g bower polylint web-component-tester
- bower install
- polylint
- npm install -g bower polymer-cli@next
- polymer install --variants
env:
global:
- secure: >-
YMlrRxFp8QBJ9KfvrPru2sIaHm5GeVHsZ/wE4qm5ntdsoqQlsJXRYYhlE2jPSHte+2VrOnFItjCsoqG6myeCbMrDS+/ZAZd+PWNdxbSs0DiGVMJWtrd8PwhKeOoVYzJleTwU0Uj2mF/mKwoC6aNgf56V9XzC2mkooRJX9cDbCkfddcIGoU/45zsPPMJV+BRVDcETw5g0PD+7NJBPtJP+d8TMO+jtdgXQ1V0vPJhkS7RaYZoDeljsml/Xc8Djb3zUttu5cFk4lXeKAKtFgFzxVsFqytxuYY2aSkMcq2/KxwexnnK/SCe5uQC014TjYAMzSs5A7l/ZBEzRGDhxKmkR2JHY3ktRCOFphqrQa9JoK3k+Tc28JeXJXTXNW7B5SODclN45ik5jQQ/FaJgRlideK07LsEObC9FjEoSd0U5rt75bzIhGuBQ6vr16JQLtN7+NvPRMsNqZRGHQysbW7SbfuLdWwmprn8kXaiQoensAnWlrrGoaPtPfKgA68YRQ/2cr9zZWFmMTzfDP6/Y8YSulj1mzqP2U8AZStXZ1vKN7IWY/ADzYrRG/nCqwd8gQpQoiAEgOfc+de5fIzLPRfLS8fI8sow9yZC8hE91JDatxOPvg/YCDGfJUQddCG+Z3LIBqY6RYKjXzCTCexGD6XWIJso8x5HEEWEQKArqT6vLM4gE=
- secure: >-
yNGht7DLQ56gIwWh+Wu/3spWaIo0qR/EXB7SDzGtE7Y1KLbgYjmGCnA+3Y+vQ8q9Smpv66FMi8ejbBnObb347806LykEG23OJWBbruUi3gGoImNqLmaj+iqxiaYzxqIWs7gwhpYMdNGFiu1T83eBLOLoVQqO1OIIVbH1Fk0MvHvbknY52VyOEaEjVBdnWAxTpDdgujzVaPBxaPCbD15nUFgaMCsBdR0SKtX0X+vVZRdu0VzHqLJPhUxrQJIxdAYc/OyEKki5pR93b0df+0P14NHxduWNtaAReBtMtpVsiLfaxiHdoWzjHdJ2g+x4DEoH1ynbs4v/8qWE1xLABcgHK2UeZYwTtk7KSA9ZcYSx7JxnO1mhseWdiCSKO4Y0bZuBcSsQ9O5skvIOhAd9bLdQHMe4bHSf8mhtv/Kw6IHmEqZ9YZ8TIk7YY4bYiLOKsN6q2kYbWO7UVeYBLul3mppiEWZ04JmbjVU5us1hq40RdSsc34/fW3KitLfVaYQlTWlZ/h9nx7tOQ2o6OOSHgRnD8qPpFM+xExqkj2FIgUWyecn8VKQ6FojgfOeVyEQ3WdPK17LdFxhKfHVod+Qufl6ArBsUMWctns4/jQTCJXL+VIPfZWQ/wrYmkIW7dEjA6NnTMBqhjBa37C1G8+Ak5kvSAcU4iAbjqA1jVv4RANRV5x8=
- secure: YMlrRxFp8QBJ9KfvrPru2sIaHm5GeVHsZ/wE4qm5ntdsoqQlsJXRYYhlE2jPSHte+2VrOnFItjCsoqG6myeCbMrDS+/ZAZd+PWNdxbSs0DiGVMJWtrd8PwhKeOoVYzJleTwU0Uj2mF/mKwoC6aNgf56V9XzC2mkooRJX9cDbCkfddcIGoU/45zsPPMJV+BRVDcETw5g0PD+7NJBPtJP+d8TMO+jtdgXQ1V0vPJhkS7RaYZoDeljsml/Xc8Djb3zUttu5cFk4lXeKAKtFgFzxVsFqytxuYY2aSkMcq2/KxwexnnK/SCe5uQC014TjYAMzSs5A7l/ZBEzRGDhxKmkR2JHY3ktRCOFphqrQa9JoK3k+Tc28JeXJXTXNW7B5SODclN45ik5jQQ/FaJgRlideK07LsEObC9FjEoSd0U5rt75bzIhGuBQ6vr16JQLtN7+NvPRMsNqZRGHQysbW7SbfuLdWwmprn8kXaiQoensAnWlrrGoaPtPfKgA68YRQ/2cr9zZWFmMTzfDP6/Y8YSulj1mzqP2U8AZStXZ1vKN7IWY/ADzYrRG/nCqwd8gQpQoiAEgOfc+de5fIzLPRfLS8fI8sow9yZC8hE91JDatxOPvg/YCDGfJUQddCG+Z3LIBqY6RYKjXzCTCexGD6XWIJso8x5HEEWEQKArqT6vLM4gE=
- secure: yNGht7DLQ56gIwWh+Wu/3spWaIo0qR/EXB7SDzGtE7Y1KLbgYjmGCnA+3Y+vQ8q9Smpv66FMi8ejbBnObb347806LykEG23OJWBbruUi3gGoImNqLmaj+iqxiaYzxqIWs7gwhpYMdNGFiu1T83eBLOLoVQqO1OIIVbH1Fk0MvHvbknY52VyOEaEjVBdnWAxTpDdgujzVaPBxaPCbD15nUFgaMCsBdR0SKtX0X+vVZRdu0VzHqLJPhUxrQJIxdAYc/OyEKki5pR93b0df+0P14NHxduWNtaAReBtMtpVsiLfaxiHdoWzjHdJ2g+x4DEoH1ynbs4v/8qWE1xLABcgHK2UeZYwTtk7KSA9ZcYSx7JxnO1mhseWdiCSKO4Y0bZuBcSsQ9O5skvIOhAd9bLdQHMe4bHSf8mhtv/Kw6IHmEqZ9YZ8TIk7YY4bYiLOKsN6q2kYbWO7UVeYBLul3mppiEWZ04JmbjVU5us1hq40RdSsc34/fW3KitLfVaYQlTWlZ/h9nx7tOQ2o6OOSHgRnD8qPpFM+xExqkj2FIgUWyecn8VKQ6FojgfOeVyEQ3WdPK17LdFxhKfHVod+Qufl6ArBsUMWctns4/jQTCJXL+VIPfZWQ/wrYmkIW7dEjA6NnTMBqhjBa37C1G8+Ak5kvSAcU4iAbjqA1jVv4RANRV5x8=
node_js: '6'
addons:
firefox: latest
Expand All @@ -19,6 +16,6 @@ addons:
packages:
- google-chrome-stable
script:
- xvfb-run wct
- 'if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then wct -s ''default''; fi'
- xvfb-run polymer test
- 'if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then polymer test -s ''default''; fi'
dist: trusty
46 changes: 33 additions & 13 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "iron-dropdown",
"version": "1.5.5",
"version": "2.0.0",
"description": "An unstyled element that works similarly to a native browser select",
"authors": [
"The Polymer Authors"
Expand All @@ -19,20 +19,40 @@
"license": "http://polymer.github.io/LICENSE.txt",
"homepage": "https://github.com/PolymerElements/iron-dropdown",
"dependencies": {
"polymer": "polymer/polymer#^1.1.0",
"iron-behaviors": "polymerelements/iron-behaviors#^1.0.0",
"iron-overlay-behavior": "polymerelements/iron-overlay-behavior#^1.8.6",
"iron-resizable-behavior": "polymerelements/iron-resizable-behavior#^1.0.0",
"neon-animation": "polymerelements/neon-animation#^1.0.0"
"polymer": "Polymer/polymer#^2.0.0-rc.1",
"iron-behaviors": "polymerelements/iron-behaviors#2.0-preview",
"iron-overlay-behavior": "PolymerElements/iron-overlay-behavior#2.0-preview",
"neon-animation": "PolymerElements/neon-animation#2.0-preview"
},
"devDependencies": {
"iron-component-page": "polymerelements/iron-component-page#^1.0.0",
"test-fixture": "polymerelements/test-fixture#^1.0.0",
"iron-test-helpers": "polymerelements/iron-test-helpers#^1.0.0",
"paper-styles": "polymerelements/paper-styles#^1.0.0",
"webcomponentsjs": "webcomponents/webcomponentsjs#^0.7.0",
"web-component-tester": "^4.0.0",
"iron-image": "polymerelements/iron-image#^1.0.0"
"iron-component-page": "polymerelements/iron-component-page#2.0-preview",
"iron-demo-helpers": "PolymerElements/iron-demo-helpers#2.0-preview",
"iron-test-helpers": "PolymerElements/iron-test-helpers#2.0-preview",
"web-animations-js": "web-animations/web-animations-js#^2.2.0",
"iron-image": "polymerelements/iron-image#2.0-preview",
"test-fixture": "PolymerElements/test-fixture#^3.0.0-rc.1",
"web-component-tester": "Polymer/web-component-tester#^6.0.0-prerelease.6",
"webcomponentsjs": "webcomponents/webcomponentsjs#^1.0.0-rc.1"
},
"variants": {
"1.x": {
"dependencies": {
"polymer": "Polymer/polymer#^1.7.0",
"iron-behaviors": "polymerelements/iron-behaviors#^1.0.0",
"iron-overlay-behavior": "PolymerElements/iron-overlay-behavior#^1.8.6",
"neon-animation": "PolymerElements/neon-animation#^1.0.0"
},
"devDependencies": {
"iron-component-page": "polymerelements/iron-component-page#^1.0.0",
"iron-demo-helpers": "PolymerElements/iron-demo-helpers#^1.0.0",
"iron-test-helpers": "PolymerElements/iron-test-helpers#^1.0.0",
"web-animations-js": "web-animations/web-animations-js#^2.2.0",
"iron-image": "polymerelements/iron-image#^1.0.0",
"test-fixture": "PolymerElements/test-fixture#^1.0.0",
"web-component-tester": "^4.0.0",
"webcomponentsjs": "webcomponents/webcomponentsjs#^0.7.0"
}
}
},
"ignore": []
}
197 changes: 113 additions & 84 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,26 @@
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<html>

<head>

<title>iron-dropdown</title>

<script src="../../webcomponentsjs/webcomponents-lite.js"></script>

<link rel="import" href="../../iron-image/iron-image.html">
<link rel="import" href="../../paper-styles/demo-pages.html">
<link rel="import" href="../../iron-demo-helpers/demo-snippet.html">
<link rel="import" href="../../iron-demo-helpers/demo-pages-shared-styles.html">
<link rel="import" href="../../neon-animation/web-animations.html">

<link rel="import" href="x-select.html">
<style>

<custom-style><style is="custom-style" include="demo-pages-shared-styles">
demo-snippet {
--demo-snippet-code: {
max-height: 250px;
}
}

.dropdown-content {
background-color: white;
Expand All @@ -44,12 +55,7 @@
border-color: blue;
}

ul {
margin: 0;
padding: 0;
}

li {
ul, li {
display: block;
position: relative;
margin: 0;
Expand Down Expand Up @@ -77,84 +83,107 @@
box-shadow: 0px 2px 6px #ccc;
border-radius: 3px;
}
</style>
</style></custom-style>
</head>
<body>
<template is="dom-bind" id="Demo">
<div class="vertical-section vertical-section-container ">
<h1>iron-dropdown</h1>
<p>Examples of vanilla elements.</p>
<div>
<x-select>
<button class="dropdown-trigger">Basic</button>
<div class="dropdown-content random-content">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</div>
</x-select>
<x-select>
<button class="dropdown-trigger">Overflowing</button>
<div class="dropdown-content random-content">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
<p>Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum quia dolor sit amet, consectetur, adipisci velit, sed quia non numquam eius modi tempora incidunt ut labore et dolore magnam aliquam quaerat voluptatem. Ut enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit laboriosam, nisi ut aliquid ex ea commodi consequatur? Quis autem vel eum iure reprehenderit qui in ea voluptate velit esse quam nihil molestiae consequatur, vel illum qui dolorem eum fugiat quo voluptas nulla pariatur?</p>
</div>
</x-select>
<x-select vertical-align="bottom">
<button class="dropdown-trigger">Bottom-left Aligned</button>
<div class="dropdown-content random-content">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</div>
</x-select>
<x-select horizontal-align="right" vertical-align="top">
<button class="dropdown-trigger">Top-right Aligned</button>
<div class="dropdown-content random-content">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</div>
</x-select>
<x-select horizontal-align="left" vertical-align="top">
<button class="dropdown-trigger"> Content</button>
<iron-image class="dropdown-content" src="../../iron-image/demo/polymer.svg"></iron-image>
</x-select>
<x-select horizontal-align="right" vertical-align="top">
<button class="dropdown-trigger">Unordered list</button>
<ul class="dropdown-content" tabindex="0">
<template is="dom-repeat" items="[[dinosaurs]]">

<body unresolved class="centered">
<h3>Basic</h3>
<demo-snippet class="centered-demo">
<template>
<x-select>
<button slot="dropdown-trigger">Basic</button>
<div class="dropdown-content random-content">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor
in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</div>
</x-select>
<x-select>
<button slot="dropdown-trigger">Overflowing</button>
<div class="dropdown-content random-content">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute
irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
<p>Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem
quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum quia dolor sit amet, consectetur, adipisci velit, sed quia non numquam
eius modi tempora incidunt ut labore et dolore magnam aliquam quaerat voluptatem. Ut enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit laboriosam, nisi ut aliquid ex ea commodi consequatur? Quis autem vel eum iure
reprehenderit qui in ea voluptate velit esse quam nihil molestiae consequatur, vel illum qui dolorem eum fugiat quo voluptas nulla pariatur?</p>
</div>
</x-select>
</template>
</demo-snippet>

<h3>Alignment</h3>
<demo-snippet class="centered-demo">
<template>
<x-select vertical-align="bottom">
<button slot="dropdown-trigger">Bottom-left Aligned</button>
<div class="dropdown-content random-content">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor
in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</div>
</x-select>
<x-select horizontal-align="right" vertical-align="top">
<button slot="dropdown-trigger">Top-right Aligned</button>
<div class="dropdown-content random-content">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor
in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</div>
</x-select>
</template>
</demo-snippet>

<h3>Content</h3>
<demo-snippet class="centered-demo">
<template>
<x-select horizontal-align="left" vertical-align="top">
<button slot="dropdown-trigger">Content</button>
<iron-image class="dropdown-content" src="../../iron-image/demo/polymer.svg"></iron-image>
</x-select>
<x-select horizontal-align="right" vertical-align="top">
<button slot="dropdown-trigger">Unordered list</button>
<ul class="dropdown-content" tabindex="0">
<dom-repeat id="Demo">
<template>
<li><a href="javascript:void(0)">[[item]]</a></li>
</template>
</ul>
</x-select>
</div>
</div>
</template>

<script>
Demo.dinosaurs = [
'allosaurus',
'brontosaurus',
'carcharodontosaurus',
'diplodocus',
'ekrixinatosaurus',
'fukuiraptor',
'gallimimus',
'hadrosaurus',
'iguanodon',
'jainosaurus',
'kritosaurus',
'liaoceratops',
'megalosaurus',
'nemegtosaurus',
'ornithomimus',
'protoceratops',
'quetecsaurus',
'rajasaurus',
'stegosaurus',
'triceratops',
'utahraptor',
'vulcanodon',
'wannanosaurus',
'xenoceratops',
'yandusaurus',
'zephyrosaurus'
];
</script>
</dom-repeat>
</ul>
</x-select>

<script>
Demo.items = [
'allosaurus',
'brontosaurus',
'carcharodontosaurus',
'diplodocus',
'ekrixinatosaurus',
'fukuiraptor',
'gallimimus',
'hadrosaurus',
'iguanodon',
'jainosaurus',
'kritosaurus',
'liaoceratops',
'megalosaurus',
'nemegtosaurus',
'ornithomimus',
'protoceratops',
'quetecsaurus',
'rajasaurus',
'stegosaurus',
'triceratops',
'utahraptor',
'vulcanodon',
'wannanosaurus',
'xenoceratops',
'yandusaurus',
'zephyrosaurus'
];
</script>
</template>
</demo-snippet>



</body>

</html>
4 changes: 2 additions & 2 deletions demo/x-select.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
}
</style>
<div on-tap="open">
<content select=".dropdown-trigger"></content>
<slot name="dropdown-trigger"></slot>
</div>
<iron-dropdown id="dropdown"
vertical-align="[[verticalAlign]]"
horizontal-align="[[horizontalAlign]]"
disabled="[[disabled]]"
open-animation-config="[[openAnimationConfig]]"
close-animation-config="[[closeAnimationConfig]]">
<content select=".dropdown-content"></content>
<slot></slot>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Discussion in paper-menu-button for reference: https://github.com/PolymerElements/paper-menu-button/pull/105/files#r109993878)
I think we should convert this to a named slot like dropdown-trigger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this as an occasion to update iron-dropdown to be less selective, but since that could be seen as a breaking change (e.g. this example) it's probably best to keep that strict selectiveness via a named slot. Will update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</iron-dropdown>
</template>
<script>
Expand Down
Loading