This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Don't run tests until the page is under SW control #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface @wibblymat @addyosmani @ebidel
As it turns out, @guantface ran into a similar race condition with the
.ready
promise. Switching from it to explicitly waiting onnavigator.serviceWorker.controller
seems to clear up the lingering test flakiness we were seeing.We'll be following up on the
.ready
promise flakiness out-of-band.Closes #37