This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Use document._currentScript when available #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming that the Travis failure is unrelated, |
👍
|
LGTM on the change - assuming that travis is just throwing a funny. |
|
The Travis thing has been going on for a while, and is resolved by #84 |
jeffposnick
added a commit
that referenced
this pull request
Dec 11, 2015
Use document._currentScript when available
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @wibblymat @gauntface @ebidel
CC: @wanderview
The nested conditional ternary operators are ugly, but I've got a few scenarios I need to deal with now:
document._currentScriptis set, because we've got the HTML Imports polyfill loaded and we're on a browser that supportsdocument.currentScriptin general.document._currentScriptisn't set, butdocument.currentScriptis, because we don't have the polyfill loaded.document._currentScriptnordocument.currentScriptare set, because we're in a browser that doesn't supportdocument.currentScript, i.e. IE.Closes #81.