-
Notifications
You must be signed in to change notification settings - Fork 205
Conversation
- Update appveyor.yml to support publishing of examples
@PlagueHO Another small one to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @PlagueHO and @johlju)
DscResource.Template/appveyor.yml, line 18 at r1 (raw file):
environment: gallery_api: # TODO: Chnage to correct APU key.
APU? or API?
DscResource.Template/appveyor.yml, line 19 at r1 (raw file):
gallery_api: # TODO: Chnage to correct APU key. # This API key only works for resource modules under DSC Resource Kit.
Might be worth making it clear that this particular key can only be decrypted by the PowerShell team's AppVeyor account and that if you wished to use this to publish your own module you'd need to set your own key. Non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
DscResource.Template/appveyor.yml, line 18 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
APU? or API?
Oh wait, I seemed to have reviewed an old version or something....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the comments. 😃
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @PlagueHO)
DscResource.Template/appveyor.yml, line 18 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Oh wait, I seemed to have reviewed an old version or something....
Yes, saw my mistake this morning so quickly fixed it :)
DscResource.Template/appveyor.yml, line 19 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Might be worth making it clear that this particular key can only be decrypted by the PowerShell team's AppVeyor account and that if you wished to use this to publish your own module you'd need to set your own key. Non-blocking.
Done. Improved the text, used bits from your comment 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is