Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Update DscResource.Template #411

Merged
merged 5 commits into from
Jul 6, 2018

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Jul 2, 2018

  • Update appveyor.yml to support publishing of examples

This change is Reviewable

- Update appveyor.yml to support publishing of examples
@johlju johlju added the needs review The pull request needs a code review. label Jul 2, 2018
@johlju
Copy link
Contributor Author

johlju commented Jul 3, 2018

@PlagueHO Another small one to review.

Copy link
Contributor

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @PlagueHO and @johlju)


DscResource.Template/appveyor.yml, line 18 at r1 (raw file):

environment:
  gallery_api:
    # TODO: Chnage to correct APU key.

APU? or API?


DscResource.Template/appveyor.yml, line 19 at r1 (raw file):

  gallery_api:
    # TODO: Chnage to correct APU key.
    # This API key only works for resource modules under DSC Resource Kit.

Might be worth making it clear that this particular key can only be decrypted by the PowerShell team's AppVeyor account and that if you wished to use this to publish your own module you'd need to set your own key. Non-blocking.

Copy link
Contributor

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


DscResource.Template/appveyor.yml, line 18 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

APU? or API?

Oh wait, I seemed to have reviewed an old version or something....

Copy link
Contributor Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comments. 😃

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @PlagueHO)


DscResource.Template/appveyor.yml, line 18 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Oh wait, I seemed to have reviewed an old version or something....

Yes, saw my mistake this morning so quickly fixed it :)


DscResource.Template/appveyor.yml, line 19 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Might be worth making it clear that this particular key can only be decrypted by the PowerShell team's AppVeyor account and that if you wished to use this to publish your own module you'd need to set your own key. Non-blocking.

Done. Improved the text, used bits from your comment 😁

Copy link
Contributor

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 2265cb3 into PowerShell:master Jul 6, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jul 6, 2018
@johlju johlju deleted the update-dscresource-template branch July 6, 2018 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants