Fix debugger startup hang when session still initializing #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a hang that occurs when the user starts the debugger right when the PowerShell session is still initializing. This is caused by a call to PowerShellContext.SetWorkingDirectory which isn't respecting the current state of the runspace. The fix is to ask for a RunspaceHandle to ensure that the runspace is free before attempting to set the working directory. Resolves PowerShell/vscode-powershell#632
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Add startSessionCommand handler for debugger configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a hang that occurs when the user starts the debugger
right when the PowerShell session is still initializing. This is caused
by a call to PowerShellContext.SetWorkingDirectory which isn't
respecting the current state of the runspace. The fix is to ask for a
RunspaceHandle to ensure that the runspace is free before attempting to
set the working directory.
Resolves PowerShell/vscode-powershell#632