-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hitting F5 while powershell session is still initializing breaks debugger until vscode restart #632
Comments
Thanks for the report Chris! I'll look into it. |
I hit this several times while testing the alternate-cwd branch. Was moving a bit too fast and the debugger wedges. One way it wedges is this:
Is it possible we are attempting to execute PowerShell as part of debug launch when the console is still processing profiles and such? |
Yeah, it's possible there's a conflict there. I've been seeing a stack trace like that more often now too. I've got an idea for how to fix it, will give it a shot this morning. |
since the vscode update today i am getting this periodically as well in the terminal
|
Hey Chris, thanks for sending that. This is only happening when you try to get IntelliSense when the debugger is running. I'll fix this for the next patch update. |
Tracking it with this issue: PowerShell/PowerShellEditorServices#427 |
seems to be likely the culprit on the reemergence of the intellisense not working issue i reported last week as well |
This change fixes a hang that occurs when the user starts the debugger right when the PowerShell session is still initializing. This is caused by a call to PowerShellContext.SetWorkingDirectory which isn't respecting the current state of the runspace. The fix is to ask for a RunspaceHandle to ensure that the runspace is free before attempting to set the working directory. Resolves PowerShell/vscode-powershell#632
This change fixes a hang that occurs when the user starts the debugger right when the PowerShell session is still initializing. This is caused by a call to PowerShellContext.SetWorkingDirectory which isn't respecting the current state of the runspace. The fix is to ask for a RunspaceHandle to ensure that the runspace is free before attempting to set the working directory. Resolves PowerShell/vscode-powershell#632
System Details
$PSVersionTable
:Issue Description
If you are too fast hitting the F5 key after resetting a powershell session via command palette or on initial vscode startup the debugger craps out completely and can not start a debug session (at least via F5) until a full restart of vscode then it works fine again
Attached Logs
vscode-powershell.log.txt
EditorServices.log.txt
The text was updated successfully, but these errors were encountered: