Fix variable's 'add to watch' feature. #504
Conversation
| @@ -603,7 +603,7 @@ public VariableDetailsBase GetVariableFromExpression(string variableExpression, | |||
| // of command executions into string output. However, if null is returned | |||
| // then return null so that no output gets displayed. | |||
| string outputString = | |||
| results != null ? | |||
| results != null && results.Count() > 0 ? | |||
There was a problem hiding this comment.
Possibly more efficient to use results.Any() here?
There was a problem hiding this comment.
Um ... yeah, good call! Much quicker than to count a 10000 element sequence.
|
@daviwil Before you merge a PR do you assign it a milestone or do you do that just for the related issue? |
|
I've been assigning milestones for both issues and PRs lately so I can keep track of what work got done. In this case since we don't have a new version number milestone yet we can just assign it to the June milestone. Once I'm ready to ship an update I scan through the closed items for the current month milestone and assign them to the specific version milestone. I should write up something about the milestone model since it's gone through several variations before I settled on this ;) |
Fix #838 in vscode-powershell