-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureRM Tools extension prevents PowerShell extension from loading #1016
Comments
Still present with extension 1.4.2 2017-9-8 12:09:12 [NORMAL] - Visual Studio Code v1.17.0-insider 64-bit 2017-9-8 12:09:12 [NORMAL] - Language server starting... |
Hi, I am having the same problem here: Windows 10 (1703) 15063.540 $PSVersionTable: 2017-9-8 14:03:35 [NORMAL] - Visual Studio Code v1.16.0 64-bit 2017-9-8 14:03:35 [NORMAL] - Language server starting... |
Me too: I'd upload the logs, but they are empty. I've changed the logging level to Verbose, still empty. Name Value PSVersion 5.1.15063.502 2017-9-8 09:58:50 [NORMAL] - Visual Studio Code v1.17.0-insider 64-bit 2017-9-8 09:58:50 [NORMAL] - Language server starting... Shutting down language client... Shutting down language client... Shutting down language client... |
Thanks all! @Jaykul also reported this issue to me recently but I haven't yet figured out why it's happening. The logs you've all pasted are a good starting point for investigation so I'll take a look today. |
By the way, does this problem occur for you when using VS Code Stable 1.16.0 which was released yesterday, or only in the latest Insiders builds? |
For me it happens on both Stable and Insiders. Fully removed extension and re-installed, same issue. Just fails to load Editor Services and doesn't seem to create any log files. |
Damn, not sure what happened there. Seems like it's not launching PowerShell at all. Can you try adding this setting to see if it makes any difference?
|
@daviwil , thats seems to have worked for me. The default is just "" (I can't remember if it was that normally. Adding the direct path has put everything back to how it was prior to 1.4.2 |
Thanks a lot for confirming! I'll see if I can get a fix out for that today. |
@daviwil adding the powerShellExePath doesn't work for me in the 1.16.0 build, however the extension works with the latest insider build without any changes |
@daviwil adding the powerShellExePath didn't work for me either, I'm on the 1.16 build. |
@daviwil ditto for me. I'm running VSCode 1.16 on Windows 10 1703, and adding powershell.powerShellExePath. I was hoping it was from switching VSCode from x86 to x64, but neither enabling the x86 PowerShell nor switching back to 32-bit VSCode resolved the issue |
@daviwil I got the vscode-PowerShell extension to work after disabling the 'Azure Tools for Visual Studio Code' extension by 'bradygaster', which is installed as part of the 'Azure Extension Pack' by 'Microsoft'. |
@aydeisen This worked for me too, thanks for the tip! |
@aydeisen removing the Azure tools also fixed powershell for me. And now after I added the msazurermtools.azurerm-vscode-tools extension again PowerShell still works... |
@cjrege: that extension doesn't look right. It was the |
Hey all, thanks a lot for the investigation! It definitely turns out that the Azure Tools for VS Code extension (or more accurately, one of its dependencies) is causing this issue. They use the AppInsights SDK for Node.js which hijacks some standard Node.js APIs to provide instrumentation. Their wrapper of the filesystem module is causing an error to be thrown in a way that prevents the PowerShell extension from being loaded. I've included some more details here: https://github.com/bradygaster/azure-tools-vscode/issues/46#issuecomment-328999603 Currently trying to find a workaround, I'll ship a patch update as soon as I have something. |
…on conflict This change fixes an issue that was illuminated by the AzureRM Tools extension where the `fs.appendFile` method provided by Node.js was not being called with the correct number of parameters. The AzureRM Tools extension loads up the AppInsights SDK for Node.js which in turn loads a module called Zone.js. Zone.js replaces built-in Node.js modules like `fs` to instrument their function calls. The instrumented version of that module was not as permissive on our missing `appendFile` parameter so it threw an exception which ultimately prevented the PowerShell extension from loading. This issue was fixed by populating the `callback` parameter of the `appendFile` function so that the instrumented wrapper operates correctly.
…on conflict This change fixes an issue that was illuminated by the AzureRM Tools extension where the `fs.appendFile` method provided by Node.js was not being called with the correct number of parameters. The AzureRM Tools extension loads up the AppInsights SDK for Node.js which in turn loads a module called Zone.js. Zone.js replaces built-in Node.js modules like `fs` to instrument their function calls. The instrumented version of that module was not as permissive on our missing `appendFile` parameter so it threw an exception which ultimately prevented the PowerShell extension from loading. This issue was fixed by populating the `callback` parameter of the `appendFile` function so that the instrumented wrapper operates correctly.
Just shipped 1.4.3 with a fix for this issue, let me know how it goes for you! |
@daviwil I can confirm that the Integrated terminal, along with the PowerShell extension, are now loading properly with bradygaster's Thanks for the quick turnaround. |
Fantastic, thanks for confirming, and thanks again for the diagnostic assistance! |
Great! It solves the issue. Thx a mil. |
@daviwil There is still something weird going on with this extension on macOS. I have to disable the Azure Tools for Visual Studio extension to get the PowerShell Integrated Console to display anything. If I don't disable that extension, the PowerShell Integrated Console just sits like this forever: The verbose logs don't seem to contain anything useful: |
I still experienced it on 1.4.3 as well. Had to disable Azure Tools to get the integrated console to launch. Running on Windows 8.1 though. |
I’m not seeing the issue reemerge on my Windows 10 machine. The PS Integrated Console has been taken a little longer to load, but I assume that’s more of a vscode issue than a PowerShell Extension issue.
- VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:23.027Z)
- OS Version: Windows_NT x64 10.0.15063
- Extensions:
Extension|Author (truncated)|Version
---|---|---
jslint|ajh|1.2.1
azuretoolsforvscode|bra|1.3.0
jshint|dba|0.10.15
vscode-eslint|dba|1.3.2
azure-functions-tools|joh|0.3.1
vscode-devskim|MS-|0.2.0
mssql|ms-|1.2.0
azurecli|ms-|0.3.0
csharp|ms-|1.12.1
github-issues-prs|ms-|0.6.0
js-atom-grammar|ms-|0.1.13
PowerShell|ms-|1.4.3
typescript-javascript-grammar|ms-|0.0.24
vscode-azureextensionpack|ms-|0.0.6
team|ms-|1.122.0
azurerm-vscode-tools|msa|0.3.7
vscode-docker|Pet|0.0.18
velocity|sod|0.1.0
usql-vscode-ext|usq|0.2.4
application-insights|Vis|0.4.1
azure-iot-toolkit|vsc|0.2.3
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: Andy Stumph<mailto:notifications@github.com>
Sent: Tuesday, October 3, 2017 09:41
To: PowerShell/vscode-powershell<mailto:vscode-powershell@noreply.github.com>
Cc: aydeisen<mailto:aydeisen@gmail.com>; Mention<mailto:mention@noreply.github.com>
Subject: Re: [PowerShell/vscode-powershell] AzureRM Tools extension prevents PowerShell extension from loading (#1016)
I still experienced it on 1.4.3 as well. Had to disable Azure Tools to get the integrated console to launch. Running on Windows 8.1 though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1016 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANZGFeCUzIHtG40shVZwe3vUj5Szk7z6ks5sojmKgaJpZM4PKLq5>.
|
System Details
$PSVersionTable
:Name Value
PSVersion 5.1.15063.502
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.15063.502
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
Issue Description
Basically the extension after the latest insider updates doesn't work anymore (no F8, no auto complete, and so on), in the output window I can read:
[8:58:45] Language server starting...
[8:58:45] Language server startup failed.
Attached Logs
I attach the logs, but they're empty
The text was updated successfully, but these errors were encountered: