-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.4.3 #1032
Closed
Closed
Release 1.4.3 #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the path used for PowerShell on Windows due to the fact that 64-bit VS Code has been released (and is now being promoted as the primary build). We're only pointing to the System32 path for now because VS Code doesn't provide a way to specify a different path in the 32-bit build.
This change enables Mocha-based unit tests for the PowerShell extension using VS Code's embedded test running mode.
This change introduces a new module that contains all the logic for determining the current OS platform, process architecture and OS architecture for use in determining available Windows PowerShell EXE paths. This module helps resolve problems that were introduced by the new 64-bit distribution of Visual Studio Code. Fixes #1008 Fixes #1007 Fixes #1006 Fixes #993
This change fixes #1020 which states that PowerShell session commands should activate the extension if it isn't already started. These commands are useful for activating a PowerShell session if the user doesn't currently have a PowerShell file open.
This change adds additional logging for document formatting operations to help diagnose user reported issues with this feature.
The VS Code extension test runner is failing consistently on Linux and MacOS so we are disabling it for now until we can diagnose the issue. Tracked by issue #1024.
This change fixes an issue that was illuminated by the AzureRM Tools extension where the `fs.appendFile` method provided by Node.js was not being called with the correct number of parameters. The AzureRM Tools extension loads up the AppInsights SDK for Node.js which in turn loads a module called Zone.js. Zone.js replaces built-in Node.js modules like `fs` to instrument their function calls. The instrumented version of that module was not as permissive on our missing `appendFile` parameter so it threw an exception which ultimately prevented the PowerShell extension from loading. This issue was fixed by populating the `callback` parameter of the `appendFile` function so that the instrumented wrapper operates correctly.
Now I have to remember what I did to make the 1.4.2 release merge properly... |
Recreating this from a cherry-picked branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains a fix for #1016, an issue which has been affecting quite a few users since VS Code 1.16.0 was released.