-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send worker metadata with first heartbeat #15898
Conversation
CodSpeed Performance ReportMerging #15898 will not alter performanceComparing Summary
|
…tHQ/prefect into cloud-542-worker-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I left one suggestion to send the prefect
version with the heartbeat in service of #12126, but feel free to punt on that for now and we'll come back to it.
Good suggestion! Here was my thinking on excluding it. Currently, the client already sends its version in an HTTP header, so we're capturing it that way to store in metadata server-side in the heartbeat endpoint. Does that work? We'll plan to port that to open-source when we bring the feature over. |
Yeah, that makes perfect sense to me! |
Send worker metadata with the first worker heartbeat. For now, this metadata includes the Prefect integrations installed in the current process.
NOTE: This PR only sends the data if we're connected to Cloud. Support for open-source Prefect servers will follow.
Closes CLOUD-542.
Checklist
<link to issue>
"mint.json
.