Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more helpful output in type completeness check #16327

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Dec 10, 2024

This PR improves the type completeness check by providing information about new type hinting errors.
Screenshot 2024-12-10 at 2 49 11 PM
This should help contributors see where type hinting needs to be improved to keep type completeness trending in the right direction.

Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #16327 will not alter performance

Comparing more-helpful-type-completeness-errors (6bde400) with main (7f75038)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Dec 10, 2024
@desertaxle desertaxle marked this pull request as ready for review December 10, 2024 20:51
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desertaxle desertaxle merged commit 1e1bd57 into main Dec 10, 2024
13 checks passed
@desertaxle desertaxle deleted the more-helpful-type-completeness-errors branch December 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants