improve Dockerfile build time and add CI to catch future slow downs
#16348
+125
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16348 will not alter performanceComparing Summary
|
zzstoatzz
added
the
development
zzstoatzz
commented
Dec 11, 2024
Comment on lines
+50
to
+53
| - name: Clean Docker system again | ||
| run: | | ||
| docker system prune -af | ||
| docker builder prune -af |
There was a problem hiding this comment.
avoid sharing any cache that would bias results
zzstoatzz
commented
Dec 11, 2024
Comment on lines
-98
to
-99
| curl \ | ||
| ca-certificates \ |
There was a problem hiding this comment.
i dont think we need these, and they were added in #16235, not before
zzstoatzz
force-pushed
the
add-docker-image-bench
branch
from
4a05742 to
5139936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's still work to be done here, since i'm not sure what caused the dramatically inflated runtime of the
Docker imagesjob, but now at least we can relatively quantify all changes to theDockerfileinspired by #16327 (see https://github.com/PrefectHQ/prefect/actions/runs/12284945352?pr=16348)