-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 6.0.3 #203
Release 6.0.3 #203
Conversation
boherm
commented
Mar 27, 2024
Questions | Answers |
---|---|
Description? | Release 6.0.3 |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | |
How to test? |
install.sql in root directory of module prior v5.0.1 CREATE TABLE with deprecated CHARSET=utf8. It need to be fixed in the upgrade of next version.
We are on v5.0.2 now.
@kpodemski Nearly perfect. 👍 When run directly in phpMyAdmin: my code only upgrade table collation, your code upgrade both table and its fields collation. The remaining issue is Upgrade via BO interface does not call install-**5.0.3**.php. BO upgrade suggest upgrade v5.0.2 -> v5.0.2, and I guess it called install-**5.0.2**.php instead :( Co-authored-by: Krystian Podemski <kpodemski@users.noreply.github.com>
We are on v6.0.2 now
Fix deprecated CHARSET utf8 in install and upgrade
Fix removing previous module files in PHPStan tests
…since-v400n600 Mark deprecated functions since v4.0.0 and v6.0.0
…hAPI Replace jQueryAJAX by FetchAPI
Co-authored-by: Nicolas Lœuillet <nicolas@loeuillet.org>
If user mistakenly attempts to delete a comment, fail gracefully
Remove unneeded version check
Bump version number to 6.0.3
…_QuickView_refresh disable Write your view in QuickView refresh
Make rating mandatory
Fix compatibility with Hummingbird theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all good. :-)))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @boherm ,
Upgrade to v6.0.3 went well.
Configuration of module is broken when Debug mode is enabled.
![Screenshot 2024-04-02 at 17 05 53](https://private-user-images.githubusercontent.com/16019289/318839789-82133d86-83fb-4684-9ace-e6fe6c8463fb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDY3MjIsIm5iZiI6MTcyNjE0NjQyMiwicGF0aCI6Ii8xNjAxOTI4OS8zMTg4Mzk3ODktODIxMzNkODYtODNmYi00Njg0LTlhY2UtZTZmZTZjODQ2M2ZiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEzMDcwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3NjY1YjFlMjJmMTg5NGVkMGRhNzMyNTRkNTYzMDA0OWUzZDBlMzZhZjk1N2EzOTMyYjVhYmUyOWFlZmZmNzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xXEin7tlaex8LXXIuOE8-qG61BRn7F3PBRNY-R6ARM8)
Screen.Recording.2024-04-02.at.17.01.48.mov
Could you check ?
@florine2623 I think it is a well-known issue, old SF configs in var/cache does not contain newly added service. You can solve it by applying BO > Performance > Clear Cache via Web browser, or running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @boherm and @florine2623 |