Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.0.3 #203

Merged
merged 47 commits into from
Apr 4, 2024
Merged

Release 6.0.3 #203

merged 47 commits into from
Apr 4, 2024

Conversation

boherm
Copy link
Member

@boherm boherm commented Mar 27, 2024

Questions Answers
Description? Release 6.0.3
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

leemyongpakvn and others added 30 commits June 27, 2022 09:30
@leemyongpakvn
Replace deprecated CHARSET utf8 in install.sql
552f86f
@leemyongpakvn
Upgrade deprecated charset utf8 by newer utfmb4
46e1106 
install.sql in root directory of module prior v5.0.1 CREATE TABLE with deprecated CHARSET=utf8. It need to be fixed in the upgrade of next version.
@leemyongpakvn
Update and rename install-5.0.2.php to install-5.0.3.php
27d1329 
We are on v5.0.2 now.
@leemyongpakvn
php-cs-fixer 1 space less
0ee9c91
@leemyongpakvn @kpodemski
Update upgrade/install-5.0.3.php
d18b4b1 
@kpodemski Nearly perfect. 👍 When run directly in phpMyAdmin: my code only upgrade table collation, your code upgrade both table and its fields collation.
The remaining issue is Upgrade via BO interface does not call install-**5.0.3**.php. BO upgrade suggest upgrade v5.0.2 -> v5.0.2, and I guess it called  install-**5.0.2**.php instead :(

Co-authored-by: Krystian Podemski <kpodemski@users.noreply.github.com>
@leemyongpakvn
Rename install-5.0.3.php to install-6.0.1.php
352c633
@leemyongpakvn
Update install-6.0.1.php - new v6
b49b55d
@leemyongpakvn
Rename install-6.0.1.php to install-6.0.3.php
39a9a8c 
We are on v6.0.2 now
@leemyongpakvn
Merge pull request #144 from leemyongpakvn/patch-3
ccb8fb1 
Fix deprecated CHARSET utf8 in install and upgrade
@leemyongpakvn
rm with --user root
3fb17dc
@kpodemski
Merge pull request #187 from leemyongpakvn/improved-phpstan-script
799da9d 
Fix removing previous module files in PHPStan tests
@leemyongpakvn
mark deprecated funtions
b79bfef
@leemyongpakvn
mark deprecated functions since v4.0.0 n v6.0.0
b05b70d
@leemyongpakvn
correct function name
d6078d1
@leemyongpakvn
CS fix
cbe39e0
@leemyongpakvn
Merge pull request #188 from leemyongpakvn/mark-deprecated-functions-…
b6c6cda 
…since-v400n600

Mark deprecated functions since v4.0.0 and v6.0.0
@leemyongpakvn
replace jQueryAJAX by FetchAPI
d10632a
@leemyongpakvn
lint fix
c72a8c5
@leemyongpakvn
use application/x-www-form-urlencoded to avoid changes in PHP code
1a6a64a
@nicosomb
Merge pull request #189 from leemyongpakvn/replace_jqueryAJAX_by_Fetc…
fae55dc 
…hAPI

Replace jQueryAJAX by FetchAPI
@matks
Handle bad deletion page call
4d00c37
@matks @nicosomb
Apply suggestions from code review
9ccab00 
Co-authored-by: Nicolas Lœuillet <nicolas@loeuillet.org>
@leemyongpakvn
Merge pull request #190 from matks/fix-bad-delete
96bc83c 
If user mistakenly attempts to delete a comment, fail gracefully
@leemyongpakvn
partial migration to Symfony FormData Provider n Handler
35125b4
@leemyongpakvn
replace Manual lang field process by Doctrine Entity Relation
d7a89ad
@leemyongpakvn
mark deprcated functions, replace migrated functions call by new one
a99f017
@leemyongpakvn
redundant comment
28fb214
@Hlavtox
Remove unneeded check
499fc04
@Hlavtox
Remove remaining alias usage
0061498
@Hlavtox
Merge pull request #192 from Hlavtox/modernize
e53bfe8 
Remove unneeded version check
Hlavtox and others added 12 commits January 11, 2024 13:38
@Hlavtox
Update config.xml
4cbdb61
@Hlavtox
Merge pull request #195 from Hlavtox/bump-version
c09d073 
Bump version number to 6.0.3
@leemyongpakvn
Merge pull request #193 from leemyongpakvn/disable_WriteYourReview_in…
40614d2 
…_QuickView_refresh

disable Write your view in QuickView refresh
@leemyongpakvn
make rating mandatory
fea6fa7
@leemyongpakvn
put Mandatory message inside the current modal instead of a new modal
10ddd32
@leemyongpakvn
unify
dc9c3f3
@leemyongpakvn
tweak message color and alignment
36d69ce
@leemyongpakvn
hide Mandatory message at each showPostCommentModal call
415fee7
@SharakPL
fix compatibility with hummingbird theme
51a0320
@leemyongpakvn
forced to chose rating in any new review
357a3f6
@leemyongpakvn
Merge pull request #197 from leemyongpakvn/make_rating_mandatory
f2f4d1f 
Make rating mandatory
@SharakPL
Merge pull request #198 from SharakPL/fix-compatibility-with-themes
3fe4fad 
Fix compatibility with Hummingbird theme
@boherm boherm added this to the 6.0.3 milestone Mar 27, 2024
@boherm boherm mentioned this pull request Mar 27, 2024
Closed
Hlavtox
Hlavtox approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all good. :-)))

@florine2623 florine2623 self-assigned this Mar 27, 2024
florine2623
florine2623 reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @boherm ,

Upgrade to v6.0.3 went well.
Configuration of module is broken when Debug mode is enabled.

Screenshot 2024-04-02 at 17 05 53
Screen.Recording.2024-04-02.at.17.01.48.mov

Could you check ?

@florine2623 florine2623 removed their assignment Apr 2, 2024
@leemyongpakva
Copy link
Contributor

@florine2623 I think it is a well-known issue, old SF configs in var/cache does not contain newly added service. You can solve it by applying BO > Performance > Clear Cache via Web browser, or running rm -rf /var/cache via Terminal.

@florine2623 florine2623 self-assigned this Apr 3, 2024
florine2623
florine2623 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @boherm ,

Tested the following :
#144
#190
#191
#193
#197
#198

LGTM ✅
Thanks!

@leemyongpakva leemyongpakva merged commit d47e744 into master Apr 4, 2024
16 checks passed
@leemyongpakva
Copy link
Contributor

Thanks @boherm and @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox approved these changes

@florine2623 florine2623 florine2623 approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
6.0.3
Development

Successfully merging this pull request may close these issues.
10 participants
@boherm @leemyongpakva @Hlavtox @florine2623 @ps-jarvis @leemyongpakvn @kpodemski @nicosomb @matks @SharakPL