-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog Consolidation #2888
Dialog Consolidation #2888
Conversation
3a6a7b5
to
899d79d
Compare
Interesting PR on the consolidation. On the Prism.Avalonia's side, I'm currently making some changes to the DialogService for the next 2023-Q2 release. Overall, this looks very beneficial. @dansiegel Do you foresee any integration issues? For starters, I was making the ShowDialog's Also, overloaded |
899d79d
to
fe150e6
Compare
@DamianSuess overall I think it should make it easier for you. The Core is meant to have the extensions to provide backwards compatibility. Currently the one thing which is platform specific and may still change is that the extensions for Show are in WPF since this is the only platform which implements such functionality. |
Thanks, Dan, I appreciate the feedback on the topic. |
6ec3730
to
a6b1630
Compare
a6b1630
to
a2538ea
Compare
Description of Change
This aim's to unify the Dialog abstractions to work effectively the same across all platforms. With this we gain the ability to reshare code across WPF, MAUI, Xamarin.Forms, & Uno Platform as the core interfaces reside within the Prism.Core. Note that the Show API and WindowName API in WPF & Uno Platform are now extensions for backwards compatibility . These functions are now driven through KnownDialogParamters.