Enhance/#48 aad foreign key to comments #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuri0616
reviewed
Jul 24, 2024
backend/db/Schemafile
Outdated
| t.text "content", null: false, comment: '内容' | ||
| t.datetime "created_at", null: false | ||
| t.datetime "updated_at", null: false | ||
| t.index ["memo_id"], name: "index_comments_on_memo_id" | ||
| end | ||
|
|
||
| add_foreign_key 'comments', 'memos' |
There was a problem hiding this comment.
外部キーですが明示的に名前をつける方が良いと思いました！
理由は以下の通りです！
- 外部キーが何を指しているのか明確になる
- エラーなどで問題が発生した際の発見に容易になるケースがある（ログなどに外部キー名が出力されることもある）
です！
今の状態だと以下のような自動生成された名前になっています！
CONSTRAINT `fk_rails_0f1031a78b` FOREIGN KEY (`memo_id`) REFERENCES `memos` (`id`) `
これが外部キー名になります。
fk_rails_0f1031a78b
調べた感じだと
fk_<参照元テーブル>_<参照先テーブル>_<参照するカラム>
とするパターンが多いようですね！
nameオプションをつけることで命名ができるのでそのようにお願いします🙇♂️
There was a problem hiding this comment.
コメントありがとうございます🙇♂️
Ridgepole初めて使ったので、外部キーの命名方法など、初めて知りました。勉強になります📝
外部キー名は、fk_comments_memo_idにしようと思います🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応するissue
対応内容