-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/#48 aad foreign key to comments #64
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
072cd4b
commentsテーブルのmemo_idに外部キー制約を付与するマイグレーションファイルを追加
nova818 ce03e44
Revert "commentsテーブルのmemo_idに外部キー制約を付与するマイグレーションファイルを追加"
nova818 34a0ddb
ridgepoleで外部キー制約を付与
nova818 156abef
Merge branch 'main' into enhance/#48-add-foreign-key-to-comments
kuri0616 c550f38
外部キー名を変更
nova818 4a7d89b
Merge branch 'main' into enhance/#48-add-foreign-key-to-comments
nova818 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
外部キーですが明示的に名前をつける方が良いと思いました!
理由は以下の通りです!
です!
今の状態だと以下のような自動生成された名前になっています!
これが外部キー名になります。
fk_rails_0f1031a78b
調べた感じだと
fk_<参照元テーブル>_<参照先テーブル>_<参照するカラム>
とするパターンが多いようですね!
nameオプションをつけることで命名ができるのでそのようにお願いします🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントありがとうございます🙇♂️
Ridgepole初めて使ったので、外部キーの命名方法など、初めて知りました。勉強になります📝
外部キー名は、fk_comments_memo_idにしようと思います🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!