[FIX CRO-387] fix rule's type is editable

ProgrammeVitam · Mar 19, 2024 · 0027e37 · 0027e37
1 parent ca48e55
commit 0027e37
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/...ential/src/app/rule/rule-preview/rule-information-tab/rule-information-tab.component.html b/...ential/src/app/rule/rule-preview/rule-information-tab/rule-information-tab.component.html
@@ -1,12 +1,7 @@
 <form [formGroup]="form" class="side-form" (ngSubmit)="onSubmit()">
   <div class="d-flex">
     <mat-form-field class="vitamui-mat-select w-100">
-      <mat-select
-        formControlName="ruleType"
-        [placeholder]="'RULES_APP.TAB.INFORMATION.TYPE' | translate"
-        required
-        [disabled]="(hasUpdateAgencyRole$ | async) !== true"
-      >
+      <mat-select formControlName="ruleType" [placeholder]="'RULES_APP.TAB.INFORMATION.TYPE' | translate" required [disabled]="true">
         <mat-option *ngFor="let ruleType of ruleTypes" [value]="ruleType.key">{{ ruleType.label }}</mat-option>
       </mat-select>
       <div class="select-arrow"><i class="material-icons">keyboard_arrow_down</i></div>
@@ -20,7 +15,7 @@
       minlength="2"
       required
       [placeholder]="'RULES_APP.TAB.INFORMATION.NAME' | translate"
-      [disabled]="(hasUpdateAgencyRole$ | async) !== true"
+      [disabled]="(hasUpdateRuleRole$ | async) !== true"
     >
       <ng-container *ngIf="form.get('ruleValue')?.touched">
         <vitamui-common-input-error *ngIf="!!form.get('ruleValue')?.errors?.required">
@@ -37,7 +32,7 @@
       pattern="[0-9]*"
       required
       [placeholder]="'RULES_APP.TAB.INFORMATION.PERIOD' | translate"
-      [disabled]="(hasUpdateAgencyRole$ | async) !== true"
+      [disabled]="(hasUpdateRuleRole$ | async) !== true"
     >
       <ng-container *ngIf="form.get('ruleDuration')?.touched">
         <vitamui-common-input-error *ngIf="!!form.get('ruleDuration')?.errors?.required">
@@ -53,7 +48,7 @@
         formControlName="ruleMeasurement"
         [placeholder]="'RULES_APP.TAB.INFORMATION.UNIT_MEASURE' | translate"
         required
-        [disabled]="(hasUpdateAgencyRole$ | async) !== true"
+        [disabled]="(hasUpdateRuleRole$ | async) !== true"
       >
         <mat-option *ngFor="let ruleMeasurement of ruleMeasurements" [value]="ruleMeasurement.key">
           {{ ruleMeasurement.label }}
@@ -68,7 +63,7 @@
       class="w-100"
       required
       formControlName="ruleDescription"
-      [disabled]="(hasUpdateAgencyRole$ | async) !== true"
+      [disabled]="(hasUpdateRuleRole$ | async) !== true"
       [placeholder]="'RULES_APP.TAB.INFORMATION.DESCRIPTION' | translate"
       [rows]="2"
     >
@@ -81,11 +76,7 @@
   </div>
 
   <div class="actions mt-5">
-    <button
-      type="submit"
-      class="btn primary"
-      [disabled]="isInvalid() || unchanged() || submited || (hasUpdateAgencyRole$ | async) !== true"
-    >
+    <button type="submit" class="btn primary" [disabled]="isInvalid() || unchanged() || submited || (hasUpdateRuleRole$ | async) !== true">
       {{ 'COMMON.SAVE' | translate }}
     </button>
   </div>

diff --git a/...erential/src/app/rule/rule-preview/rule-information-tab/rule-information-tab.component.ts b/...erential/src/app/rule/rule-preview/rule-information-tab/rule-information-tab.component.ts
@@ -63,7 +63,7 @@ export class RuleInformationTabComponent implements OnInit {
   ruleMeasurements = RULE_MEASUREMENTS;
 
   tenantIdentifier: number;
-  hasUpdateAgencyRole$: Observable<boolean>;
+  hasUpdateRuleRole$: Observable<boolean>;
 
   private oldRule: Rule;
 
@@ -108,7 +108,7 @@ export class RuleInformationTabComponent implements OnInit {
   }
 
   ngOnInit() {
-    this.hasUpdateAgencyRole$ = this.route.params.pipe(
+    this.hasUpdateRuleRole$ = this.route.params.pipe(
       mergeMap((params) => {
         this.tenantIdentifier = +params.tenantIdentifier;
         return this.securityService.hasRole(RULES_APP, this.tenantIdentifier, VitamuiRoles.ROLE_UPDATE_RULES);