Skip to content

Commit

Permalink
Story #13593: add query params to archive-search, collect & logbook-m…
Browse files Browse the repository at this point in the history
…gt-opt
  • Loading branch information
Regzox authored and marob committed Feb 4, 2025
1 parent 95a12bc commit 3323a68
Show file tree
Hide file tree
Showing 56 changed files with 1,302 additions and 1,152 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ import { ArchiveService } from '../../archive.service';
import { ArchiveUnitObjectsDetailsTabComponent } from './archive-unit-objects-details-tab.component';
import createSpyObj = jasmine.createSpyObj;
import anything = jasmine.anything;
import { ActivatedRoute } from '@angular/router';

describe('ArchiveUnitObjectsDetailsTabComponent tests', () => {
describe('ArchiveUnitObjectsDetailsTabComponent', () => {
let component: ArchiveUnitObjectsDetailsTabComponent;
let fixture: ComponentFixture<ArchiveUnitObjectsDetailsTabComponent>;
const clipboardSpy = createSpyObj<Clipboard>('Clipboard', ['copy']);
Expand Down Expand Up @@ -98,6 +99,12 @@ describe('ArchiveUnitObjectsDetailsTabComponent tests', () => {
{ provide: TenantSelectionService, useValue: tenantSelectionServiceSpy },
{ provide: Clipboard, useValue: clipboardSpy },
{ provide: AccessContractService, useValue: accessContractServiceMock },
{
provide: ActivatedRoute,
useValue: {
queryParams: of(),
},
},
],
schemas: [NO_ERRORS_SCHEMA],
}).compileComponents();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog';
import { Subscription, merge } from 'rxjs';
import { debounceTime, filter, map } from 'rxjs/operators';
import {
ActionOnCriteria,
CriteriaDataType,
CriteriaOperator,
CriteriaValue,
Expand Down Expand Up @@ -153,9 +152,9 @@ export class AccessRuleSearchComponent implements OnInit, OnDestroy {
.receiveAccessFromMainSearchCriteriaSubject()
.subscribe((criteria) => {
if (criteria) {
if (this.accessAdditionalCriteria && criteria.action === ActionOnCriteria.ADD) {
if (this.accessAdditionalCriteria && criteria.action === 'ADD') {
this.accessAdditionalCriteria.set(criteria.valueElt.value, true);
} else if (criteria.action === ActionOnCriteria.REMOVE) {
} else if (criteria.action === 'REMOVE') {
if (this.accessAdditionalCriteria && this.accessAdditionalCriteria.has(criteria.valueElt.value)) {
this.accessAdditionalCriteria.set(criteria.valueElt.value, false);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog';
import { Subscription, merge } from 'rxjs';
import { debounceTime, filter, map } from 'rxjs/operators';
import {
ActionOnCriteria,
CriteriaDataType,
CriteriaOperator,
CriteriaValue,
Expand Down Expand Up @@ -173,9 +172,9 @@ export class AppraisalRuleSearchComponent implements OnInit, OnDestroy {
.receiveAppraisalFromMainSearchCriteriaSubject()
.subscribe((criteria) => {
if (criteria) {
if (criteria.action === ActionOnCriteria.ADD) {
if (criteria.action === 'ADD') {
this.appraisalAdditionalCriteria.set(criteria.valueElt.value, true);
} else if (criteria.action === ActionOnCriteria.REMOVE) {
} else if (criteria.action === 'REMOVE') {
if (this.appraisalAdditionalCriteria && this.appraisalAdditionalCriteria.has(criteria.valueElt.value)) {
this.appraisalAdditionalCriteria.set(criteria.valueElt.value, false);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog';
import { Subscription, merge } from 'rxjs';
import { debounceTime, filter, map } from 'rxjs/operators';
import {
ActionOnCriteria,
CriteriaDataType,
CriteriaOperator,
CriteriaValue,
Expand Down Expand Up @@ -153,9 +152,9 @@ export class DisseminationRuleSearchComponent implements OnInit, OnDestroy {
.receiveDisseminationFromMainSearchCriteriaSubject()
.subscribe((criteria) => {
if (criteria) {
if (this.disseminationAdditionalCriteria && criteria.action === ActionOnCriteria.ADD) {
if (this.disseminationAdditionalCriteria && criteria.action === 'ADD') {
this.disseminationAdditionalCriteria.set(criteria.valueElt.value, true);
} else if (criteria.action === ActionOnCriteria.REMOVE) {
} else if (criteria.action === 'REMOVE') {
if (this.disseminationAdditionalCriteria && this.disseminationAdditionalCriteria.has(criteria.valueElt.value)) {
this.disseminationAdditionalCriteria.set(criteria.valueElt.value, false);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog';
import { Subscription, merge } from 'rxjs';
import { debounceTime, filter, map } from 'rxjs/operators';
import {
ActionOnCriteria,
CriteriaDataType,
CriteriaOperator,
CriteriaValue,
Expand Down Expand Up @@ -153,9 +152,9 @@ export class ReuseRuleSearchComponent implements OnInit, OnDestroy {
.receiveReuseFromMainSearchCriteriaSubject()
.subscribe((criteria) => {
if (criteria) {
if (this.reuseAdditionalCriteria && criteria.action === ActionOnCriteria.ADD) {
if (this.reuseAdditionalCriteria && criteria.action === 'ADD') {
this.reuseAdditionalCriteria.set(criteria.valueElt.value, true);
} else if (criteria.action === ActionOnCriteria.REMOVE) {
} else if (criteria.action === 'REMOVE') {
if (this.reuseAdditionalCriteria && this.reuseAdditionalCriteria.has(criteria.valueElt.value)) {
this.reuseAdditionalCriteria.set(criteria.valueElt.value, false);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog';
import { Subscription, merge } from 'rxjs';
import { debounceTime, filter, map } from 'rxjs/operators';
import {
ActionOnCriteria,
CriteriaDataType,
CriteriaOperator,
CriteriaValue,
Expand Down Expand Up @@ -173,9 +172,9 @@ export class StorageRuleSearchComponent implements OnInit, OnDestroy {
.receiveStorageFromMainSearchCriteriaSubject()
.subscribe((criteria) => {
if (criteria) {
if (criteria.action === ActionOnCriteria.ADD) {
if (criteria.action === 'ADD') {
this.storageAdditionalCriteria.set(criteria.valueElt.value, true);
} else if (criteria.action === ActionOnCriteria.REMOVE) {
} else if (criteria.action === 'REMOVE') {
if (this.storageAdditionalCriteria && this.storageAdditionalCriteria.has(criteria.valueElt.value)) {
this.storageAdditionalCriteria.set(criteria.valueElt.value, false);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('ArchiveSearchComponent', () => {
params: of({ tenantIdentifier: 1 }),
data: of({ appId: 'ARCHIVE_SEARCH_MANAGEMENT_APP' }),
queryParamMap: of({ get: () => undefined }),
snapshot: { queryParamMap: { has: () => false } },
snapshot: { queryParamMap: { has: () => false, keys: [] } },
},
},
{ provide: MatDialog, useValue: matDialogSpy },
Expand Down
Loading

0 comments on commit 3323a68

Please sign in to comment.