refactor(json-patch-to-set-action-converter): add/replace filter

ProgrammeVitam · Jan 24, 2024 · 941a0c1 · 941a0c1
1 parent 909cdab
commit 941a0c1
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/...a/fr/gouv/vitamui/archives/search/common/dto/converter/JsonPatchToSetActionConverter.java b/...a/fr/gouv/vitamui/archives/search/common/dto/converter/JsonPatchToSetActionConverter.java
@@ -33,15 +33,18 @@
 import fr.gouv.vitam.common.database.builder.request.exception.InvalidCreateOperationException;
 import fr.gouv.vitamui.archives.search.common.model.JsonPatch;
 import fr.gouv.vitamui.archives.search.common.model.PatchCommand;
-import fr.gouv.vitamui.archives.search.common.model.PatchOperation;
 import fr.gouv.vitamui.commons.api.logger.VitamUILogger;
 import fr.gouv.vitamui.commons.api.logger.VitamUILoggerFactory;
 import org.springframework.core.convert.converter.Converter;
 import org.springframework.stereotype.Service;
 
+import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
 
+import static fr.gouv.vitamui.archives.search.common.model.PatchOperation.ADD;
+import static fr.gouv.vitamui.archives.search.common.model.PatchOperation.REPLACE;
+
 @Service
 public class JsonPatchToSetActionConverter implements Converter<JsonPatch, SetAction> {
 
@@ -51,11 +54,7 @@ public class JsonPatchToSetActionConverter implements Converter<JsonPatch, SetAc
     @Override
     public SetAction convert(JsonPatch source) {
         final Map<String, JsonNode> map = source.stream()
-            .filter(patchCommand -> {
-                final boolean isAdd = patchCommand.getOp() == PatchOperation.ADD;
-                final boolean isReplace = patchCommand.getOp() == PatchOperation.REPLACE;
-                return isAdd || isReplace;
-            })
+            .filter(patchCommand -> List.of(ADD, REPLACE).contains(patchCommand.getOp()))
             .collect(Collectors.toMap(PatchCommand::getPath, PatchCommand::getValue));
         if (!map.isEmpty()) {
             try {