Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS] clean code : use same unit between angular apps #1210

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[VAS] clean code : use same unit between angular apps #1210

merged 1 commit into from
Feb 22, 2023

Conversation

laedanrex
Copy link
Contributor

@laedanrex laedanrex commented Feb 14, 2023 •
edited by oussamasic
Loading

Description

Description des modifications
Mutualisation de dto/model unit

Contributeur

VAS (Vitam Accessible en Service)

@laedanrex laedanrex added javascript Pull requests that update Javascript code small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer VAS VAS contribution clean Code Clean Code VitamUI labels Feb 14, 2023
@laedanrex laedanrex self-assigned this Feb 14, 2023
@GiooDev GiooDev added this to the IT 115 milestone Feb 14, 2023
Regzox
Regzox approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Regzox Regzox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les interfaces liées aux Unit sont bien mises dans frontend-common.

@bbenaissa
Copy link
Collaborator

à modifier la description

@GiooDev GiooDev merged commit 94f7b02 into develop Feb 22, 2023
@GiooDev GiooDev deleted the vas-10829-clean-code branch February 22, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oussamasic oussamasic oussamasic approved these changes

@Regzox Regzox Regzox approved these changes

Assignees

@laedanrex laedanrex

Labels
clean Code Clean Code VitamUI javascript Pull requests that update Javascript code small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer VAS VAS contribution
Projects
None yet
Milestone
IT 115
Development

Successfully merging this pull request may close these issues.
5 participants
@laedanrex @bbenaissa @oussamasic @Regzox @GiooDev