Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story #11851: clean code #1563

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Story #11851: clean code #1563

merged 5 commits into from
Jan 9, 2024

Conversation

marob
Copy link
Contributor

@marob marob commented Dec 4, 2023

Description

Amélioration onboarding sur le projet et type dans la doc

Type de changement:

Clean code

@marob marob requested a review from bbenaissa December 4, 2023 09:33
@vitam-devops
Copy link
Collaborator

vitam-devops commented Dec 4, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 7809962f-77ba-4ce5-84f0-7d25739fc258

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2019-15599 Npm-tree-kill-1.2.1 Vulnerable Package
HIGH CVE-2020-28502 Npm-xmlhttprequest-ssl-1.5.5 Vulnerable Package
HIGH CVE-2020-36048 Npm-engine.io-3.2.1 Vulnerable Package
HIGH CVE-2020-36049 Npm-socket.io-parser-3.2.0 Vulnerable Package
HIGH CVE-2020-7660 Npm-serialize-javascript-1.9.1 Vulnerable Package
HIGH CVE-2020-7788 Npm-ini-1.3.5 Vulnerable Package
HIGH CVE-2021-31597 Npm-xmlhttprequest-ssl-1.5.5 Vulnerable Package
HIGH CVE-2022-2421 Npm-socket.io-parser-3.2.0 Vulnerable Package
HIGH CVE-2023-32695 Npm-socket.io-parser-3.2.0 Vulnerable Package
MEDIUM CVE-2019-16769 Npm-serialize-javascript-1.9.1 Vulnerable Package
MEDIUM CVE-2020-15366 Npm-ajv-6.10.0 Vulnerable Package
MEDIUM CVE-2020-15366 Npm-ajv-5.5.2 Vulnerable Package
MEDIUM CVE-2020-28481 Npm-socket.io-2.1.1 Vulnerable Package
MEDIUM CVE-2020-7693 Npm-sockjs-0.3.19 Vulnerable Package
MEDIUM CVE-2021-23364 Npm-browserslist-4.5.5 Vulnerable Package
MEDIUM CVE-2021-23495 Npm-karma-4.1.0 Vulnerable Package
MEDIUM CVE-2022-0437 Npm-karma-4.1.0 Vulnerable Package
MEDIUM CVE-2022-21704 Npm-log4js-4.5.1 Vulnerable Package
MEDIUM CVE-2022-41940 Npm-engine.io-3.2.1 Vulnerable Package

Fixed Issues

Severity Issue Source File / Package
HIGH Missing User Instruction /Dockerfile: 10
HIGH Missing User Instruction /Dockerfile: 11
HIGH Missing User Instruction /Dockerfile: 10
HIGH Missing User Instruction /Dockerfile: 10
HIGH No New Privileges Not Set /docker-compose.yml: 10
HIGH No New Privileges Not Set /vitam-recette.yml: 54
HIGH No New Privileges Not Set /vitam-recette.yml: 17
HIGH No New Privileges Not Set /vitam-dev.yml: 19
HIGH Passwords And Secrets - Generic Password /application.yml: 77
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 23
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 32
HIGH Passwords And Secrets - Generic Password /application.yml: 31
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 22
HIGH Passwords And Secrets - Generic Password /application.yml: 37
HIGH Passwords And Secrets - Generic Password /cas-server-application-recette.yml: 102
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 59
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 38
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 46
HIGH Passwords And Secrets - Generic Password /logstash.yml: 244
HIGH Passwords And Secrets - Generic Password /application.yml: 42
HIGH Passwords And Secrets - Generic Password /application.yml: 77
HIGH Passwords And Secrets - Generic Password /logstash.yml: 238
HIGH Passwords And Secrets - Generic Password /cas-server-application-dev.yml: 54
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 149
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 62
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 29
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 9
HIGH Passwords And Secrets - Generic Password /application.yml: 33
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 114
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 47
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 78
HIGH Passwords And Secrets - Generic Password /application.yml: 51
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 132
HIGH Passwords And Secrets - Generic Password /application-integration.yml: 47
HIGH Passwords And Secrets - Generic Password /application.yml: 65
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 24
HIGH Passwords And Secrets - Generic Password /application.yml: 54
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 75
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 31
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 56
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 91
HIGH Passwords And Secrets - Generic Password /cas-server-application-dev.yml: 19
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 71
HIGH Passwords And Secrets - Generic Password /application.yml: 44
HIGH Passwords And Secrets - Generic Password /logstash.yml: 227
HIGH Passwords And Secrets - Generic Password /application.yml: 53
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 5
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 141
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 73
HIGH Passwords And Secrets - Generic Password /application.yml: 29
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 71
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 46
HIGH Passwords And Secrets - Generic Password /application.yml: 42
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 54
HIGH Passwords And Secrets - Generic Password /application.yml: 40
HIGH Passwords And Secrets - Generic Password /cas-server-application-recette.yml: 13
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 50
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 93
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 50
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 62
HIGH Passwords And Secrets - Generic Password /application.yml: 30
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 52
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 21
HIGH Passwords And Secrets - Generic Password /application.yml: 44
HIGH Passwords And Secrets - Generic Password /application.yml: 41
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 124
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 90
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 51
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 80
HIGH Passwords And Secrets - Generic Password /application.yml: 75
HIGH Passwords And Secrets - Generic Password /application-integration.yml: 50
HIGH Passwords And Secrets - Generic Password /application.yml: 39
HIGH Passwords And Secrets - Generic Password /application.yml: 27
HIGH Passwords And Secrets - Generic Password /application.yml: 97
HIGH Passwords And Secrets - Generic Password /vitamui_vars.yml: 305
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 77
HIGH Passwords And Secrets - Generic Password /application.yml: 44
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 115
HIGH Passwords And Secrets - Generic Password /application.yml: 27
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 22
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 87
HIGH Passwords And Secrets - Generic Password /application.yml: 81
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 64
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 22
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 30
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 19
HIGH Passwords And Secrets - Generic Password /application-integration.yml: 66
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 22
HIGH Passwords And Secrets - Generic Password /cas-server-application-recette.yml: 37
HIGH Passwords And Secrets - Generic Password /cas-server-application-dev.yml: 220
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 22
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 41
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 26
HIGH Passwords And Secrets - Generic Password /application.yml: 40
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 71
HIGH Passwords And Secrets - Generic Password /cas-server-application-dev.yml: 15
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 89
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 131
HIGH Passwords And Secrets - Generic Password /Dockerfile: 67
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 23
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 99
HIGH Passwords And Secrets - Generic Password /application.yml: 41
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 58
HIGH Passwords And Secrets - Generic Password /application.yml: 97
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 40
HIGH Passwords And Secrets - Generic Password /application.yml: 28
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 33
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 48
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 60
HIGH Passwords And Secrets - Generic Password /application.yml: 27
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 36
HIGH Passwords And Secrets - Generic Password /application.yml: 31
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 52
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 21
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 21
HIGH Passwords And Secrets - Generic Password /logstash.yml: 225
HIGH Passwords And Secrets - Generic Password /application.yml: 40
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 35
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 62
HIGH Passwords And Secrets - Generic Password /application.yml: 77
HIGH Passwords And Secrets - Generic Password /cas-server-application-recette.yml: 33
HIGH Passwords And Secrets - Generic Password /application.yml: 31
HIGH Passwords And Secrets - Generic Password /application.yml: 27
HIGH Passwords And Secrets - Generic Password /application.yml: 76
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 52
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 55
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 23
HIGH Passwords And Secrets - Generic Password /application.yml: 47
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 49
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 118
HIGH Passwords And Secrets - Generic Password /application.yml: 76
HIGH Passwords And Secrets - Generic Password /cas-server-application-dev.yml: 14
HIGH Passwords And Secrets - Generic Password /application.yml: 53
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 96
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 34
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 58
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 32
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 72
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 82
HIGH Passwords And Secrets - Generic Password /application-integration.yml: 12
HIGH Passwords And Secrets - Generic Password /logstash.yml: 242
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 128
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 47
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 66
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 91
HIGH Passwords And Secrets - Generic Password /cas-server-application-recette.yml: 179
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 27
HIGH Passwords And Secrets - Generic Password /application.yml: 85
HIGH Passwords And Secrets - Generic Password /application.yml: 30
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 22
HIGH Passwords And Secrets - Generic Password /application.yml: 46
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 76
HIGH Passwords And Secrets - Generic Password /application.yml: 97
HIGH Passwords And Secrets - Generic Password /mongo_dev.yml: 37
HIGH Passwords And Secrets - Generic Password /mongo_cluster.yml: 11
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 48
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 75
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 57
HIGH Passwords And Secrets - Generic Password /logstash.yml: 221
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 101
HIGH Passwords And Secrets - Generic Password /application.yml: 42
HIGH Passwords And Secrets - Generic Password /application.yml: 57
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 20
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 68
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 108
HIGH Passwords And Secrets - Generic Password /mongo_cluster.yml: 34
HIGH Passwords And Secrets - Generic Password /cas-server-application-recette.yml: 14
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 36
HIGH Passwords And Secrets - Generic Password /application.yml: 52
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 91
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 12
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 32
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 113
HIGH Passwords And Secrets - Generic Password /mongo_vars_dev.yml: 62
HIGH Passwords And Secrets - Generic Password /cas-server-application-dev.yml: 132
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 6
HIGH Passwords And Secrets - Generic Password /application-recette.yml: 91
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 35
HIGH Passwords And Secrets - Generic Password /application-dev.yml: 33
HIGH Passwords And Secrets - Generic Password /application.yml: 57
HIGH Passwords And Secrets - Generic Password

More results are available on AST platform

@Regzox
Copy link
Contributor

Regzox commented Dec 8, 2023

Faudrait juste reword des commits pour avoir le format [tracker] #[id_ticket]... ex: story #11852 docs: ...

@Regzox Regzox added the clean Code Clean Code VitamUI label Dec 8, 2023
@marob marob force-pushed the story_11851_clean-code branch from 3263d83 to fef5fde Compare December 11, 2023 10:18
@GiooDev GiooDev changed the title Story 11851 clean code Story #11851: clean code Jan 9, 2024
@GiooDev GiooDev added this to the IT 129 milestone Jan 9, 2024
@GiooDev GiooDev merged commit 4d4e812 into develop Jan 9, 2024
1 check passed
@GiooDev GiooDev deleted the story_11851_clean-code branch January 9, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbenaissa bbenaissa bbenaissa approved these changes

@Regzox Regzox Regzox approved these changes

Assignees
No one assigned
Labels
clean Code Clean Code VitamUI
Projects
None yet
Milestone
IT 129
Development

Successfully merging this pull request may close these issues.
5 participants
@marob @vitam-devops @Regzox @bbenaissa @GiooDev