Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug #12416: handle i18n Title/Description #1727

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Bug #12416: handle i18n Title/Description #1727

merged 1 commit into from
Mar 29, 2024

Conversation

marob
Copy link
Contributor

@marob marob commented Mar 27, 2024

Description

  • Gestion des langues "fr" et "en" dans toutes les casses
  • Utilisation d'une autre langue que fr/en en fallback
  • Refactoring pour centraliser la gestion de l'extraction du Title/Description d'une Unit
  • Ajout de la gestion des langues sur la Description pour l'export CSV (seul le Title était pris en compte)
  • Ajout de FIXME pour la recherche par DSL qui cherche dans Title + Title_.fr + Title.en (idem Description) : ne fonctionne pas pour d'autres langues et ne prends pas en compte les casses non minuscules pour fr/en

Type de changement:

  • Nouveau Code

  • Refactorisation de code

Documentation:

Indiquer la documentation mise à jour

[ ] Quels sont les nouvelles documentations ?

[ ] Quels sont les modifications existantes ?

[ ] Quels sont les documentations ou sections de documentations supprimés ?

Tests:

Indiquer comment le code à été testé (manuel, environnement, TU, etc)

manuel

TU

Migration:

Indiquer si les modifications apportées impliquent une migration sur l'existant et comment la faire

Checklist:

Sélectionner les éléments de la checklist

[ ] Mon code suit le style de code de ce projet.

[ ] J'ai commenté mon code, en particulier dans les classes et les méthodes difficile à comprendre.

[ ] J'ai fait les changements correspondant dans la documentation RAML.

[ ] J'ai fait les changements correspondant dans la documentation Métier.

[ ] J'ai fait les changements correspondant dans la documentation Technique.

[ ] J'ai rajouté les tests unitaires vérifiant mes fonctionnalités.

[ ] J'ai rajouté les tests de non régression vérifiant mes fonctionnalités.

[ ] Les tests unitaires nouveaux et existants passent avec succès localement.

[ ] Toutes les dépendances ont été mergées en priorité

Contributeur

VAS (Vitam Accessible en Service)

@marob marob added bug Something isn't working javascript Pull requests that update Javascript code java Pull requests that update Java code VAS VAS contribution labels Mar 27, 2024
@marob marob added this to the IT 133 milestone Mar 27, 2024
@vitam-devops
Copy link
Collaborator

vitam-devops commented Mar 27, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 18a402ec-0f5f-4fe1-8097-6e5b9da5bd74

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2019-15599 Npm-tree-kill-1.2.1 Vulnerable Package
HIGH CVE-2020-28502 Npm-xmlhttprequest-ssl-1.5.5 Vulnerable Package
HIGH CVE-2020-36048 Npm-engine.io-3.2.1 Vulnerable Package
HIGH CVE-2020-36049 Npm-socket.io-parser-3.2.0 Vulnerable Package
HIGH CVE-2020-7660 Npm-serialize-javascript-1.9.1 Vulnerable Package
HIGH CVE-2020-7788 Npm-ini-1.3.5 Vulnerable Package
HIGH CVE-2021-31597 Npm-xmlhttprequest-ssl-1.5.5 Vulnerable Package
HIGH CVE-2022-2421 Npm-socket.io-parser-3.2.0 Vulnerable Package
MEDIUM CVE-2019-16769 Npm-serialize-javascript-1.9.1 Vulnerable Package
MEDIUM CVE-2020-15366 Npm-ajv-6.10.0 Vulnerable Package
MEDIUM CVE-2020-15366 Npm-ajv-5.5.2 Vulnerable Package
MEDIUM CVE-2020-28481 Npm-socket.io-2.1.1 Vulnerable Package
MEDIUM CVE-2020-7693 Npm-sockjs-0.3.19 Vulnerable Package
MEDIUM CVE-2021-23364 Npm-browserslist-4.5.5 Vulnerable Package
MEDIUM CVE-2022-21704 Npm-log4js-4.5.1 Vulnerable Package
MEDIUM CVE-2022-41940 Npm-engine.io-3.2.1 Vulnerable Package
LOW Log_Forging /api/api-archive-search/archive-search-internal/src/main/java/fr/gouv/vitamui/archive/internal/server/rest/ArchiveSearchInternalController.java: 285 Attack Vector
LOW Log_Forging /api/api-archive-search/archive-search-internal/src/main/java/fr/gouv/vitamui/archive/internal/server/rest/ArchiveSearchInternalController.java: 296 Attack Vector
LOW Log_Forging /api/api-archive-search/archive-search-internal/src/main/java/fr/gouv/vitamui/archive/internal/server/rest/ArchiveSearchInternalController.java: 262 Attack Vector
LOW Log_Forging /api/api-archive-search/archive-search-internal/src/main/java/fr/gouv/vitamui/archive/internal/server/rest/ArchiveSearchInternalController.java: 274 Attack Vector
LOW Log_Forging /api/api-collect/collect-internal/src/main/java/fr/gouv/vitamui/collect/internal/server/rest/TransactionArchiveUnitInternalController.java: 162 Attack Vector

Fixed Issues

Severity Issue Source File / Package
HIGH Missing User Instruction /Dockerfile: 11
HIGH Missing User Instruction /Dockerfile: 10
HIGH Missing User Instruction /Dockerfile: 10
HIGH Missing User Instruction /Dockerfile: 10
HIGH No New Privileges Not Set /vitam-dev.yml: 19
HIGH No New Privileges Not Set /vitam-recette.yml: 54
HIGH No New Privileges Not Set /vitam-recette.yml: 17
HIGH No New Privileges Not Set /docker-compose.yml: 10
HIGH Passwords And Secrets - Generic Password /mongo_cluster.yml: 34
HIGH Passwords And Secrets - Generic Password /mongo_cluster.yml: 11
HIGH Passwords And Secrets - Generic Password /mongo_dev.yml: 37
HIGH Passwords And Secrets - Generic Password /Dockerfile: 67
HIGH Passwords And Secrets - Password in URL /mongo_dev.yml: 38
HIGH Privileged Containers Enabled /docker-compose.yml: 7
HIGH Privileged Containers Enabled /vitam-recette.yml: 14
HIGH Privileged Containers Enabled /docker-compose.yml: 52
HIGH Privileged Containers Enabled /vitam-recette.yml: 51
HIGH Privileged Containers Enabled /docker-compose.yml: 21
HIGH Privileged Containers Enabled /vitam-dev.yml: 16
HIGH Volume Has Sensitive Host Directory /docker-compose.yml: 26
HIGH Volume Has Sensitive Host Directory /docker-compose.yml: 10
HIGH Volume Has Sensitive Host Directory /vitam-recette.yml: 57
HIGH Volume Has Sensitive Host Directory /vitam-dev.yml: 26
HIGH Volume Has Sensitive Host Directory /vitam-dev.yml: 27
HIGH Volume Has Sensitive Host Directory /vitam-dev.yml: 25
HIGH Volume Has Sensitive Host Directory /vitam-recette.yml: 20
HIGH Volume Has Sensitive Host Directory /docker-compose.yml: 25
HIGH Volume Has Sensitive Host Directory /docker-compose.yml: 9
MEDIUM Add Instead of Copy /Dockerfile: 15
MEDIUM Add Instead of Copy /Dockerfile: 46
MEDIUM Add Instead of Copy /Dockerfile: 47
MEDIUM Container Traffic Not Bound To Host Interface /jaeger-docker-compose.yml: 5
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 7
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 19
MEDIUM Container Traffic Not Bound To Host Interface /vitam-recette.yml: 21
MEDIUM Container Traffic Not Bound To Host Interface /mongo_cluster.yml: 39
MEDIUM Container Traffic Not Bound To Host Interface /mongo_cluster.yml: 16
MEDIUM Container Traffic Not Bound To Host Interface /mongo_dev.yml: 29
MEDIUM Container Traffic Not Bound To Host Interface /vitam-recette.yml: 58
MEDIUM Container Traffic Not Bound To Host Interface /mongo_dev.yml: 12
MEDIUM Container Traffic Not Bound To Host Interface /mongo_cluster.yml: 60
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 38
MEDIUM Container Traffic Not Bound To Host Interface /vitam-dev.yml: 28
MEDIUM Healthcheck Not Set /mongo_cluster.yml: 49
MEDIUM Healthcheck Not Set /mongo_cluster.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 49
MEDIUM Healthcheck Not Set /vitam-dev.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 17
MEDIUM Healthcheck Not Set /mongo_cluster.yml: 27
MEDIUM Healthcheck Not Set /jaeger-docker-compose.yml: 3
MEDIUM Healthcheck Not Set /vitam-recette.yml: 41
MEDIUM Healthcheck Not Set /mongo_dev.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 41
MEDIUM Healthcheck Not Set /docker-compose.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 27
MEDIUM Healthcheck Not Set /mongo_dev.yml: 25
MEDIUM Healthcheck Not Set /vitam-recette.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 4
MEDIUM Healthcheck Not Set /docker-compose.yml: 3
MEDIUM Host Namespace is Shared /docker-compose.yml: 27
MEDIUM Host Namespace is Shared /mongo_cluster.yml: 4
MEDIUM Host Namespace is Shared /docker-compose.yml: 4
MEDIUM Host Namespace is Shared /vitam-dev.yml: 4
MEDIUM Host Namespace is Shared /mongo_dev.yml: 25
MEDIUM Host Namespace is Shared /docker-compose.yml: 4
MEDIUM Host Namespace is Shared /vitam-recette.yml: 41
MEDIUM Host Namespace is Shared /docker-compose.yml: 49
MEDIUM Host Namespace is Shared /docker-compose.yml: 3
MEDIUM Host Namespace is Shared /docker-compose.yml: 41
MEDIUM Host Namespace is Shared /vitam-recette.yml: 4
MEDIUM Host Namespace is Shared /jaeger-docker-compose.yml: 3
MEDIUM Host Namespace is Shared /mongo_cluster.yml: 49
MEDIUM Host Namespace is Shared /mongo_cluster.yml: 27
MEDIUM Host Namespace is Shared /docker-compose.yml: 17
MEDIUM Host Namespace is Shared /docker-compose.yml: 4
MEDIUM Host Namespace is Shared /mongo_dev.yml: 4
MEDIUM Host Namespace is Shared /docker-compose.yml: 4
MEDIUM Image Version Not Explicit /Dockerfile: 11
MEDIUM Memory Not Limited /docker-compose.yml: 4
MEDIUM Memory Not Limited /jaeger-docker-compose.yml: 3
MEDIUM Memory Not Limited /vitam-recette.yml: 41
MEDIUM Memory Not Limited /docker-compose.yml: 41
MEDIUM Memory Not Limited /docker-compose.yml: 4
MEDIUM Memory Not Limited /mongo_cluster.yml: 49
MEDIUM Memory Not Limited /mongo_dev.yml: 25
MEDIUM Memory Not Limited /mongo_cluster.yml: 27
MEDIUM Memory Not Limited /docker-compose.yml: 49
MEDIUM Memory Not Limited /docker-compose.yml: 3
MEDIUM Memory Not Limited /docker-compose.yml: 17
MEDIUM Memory Not Limited /vitam-recette.yml: 4
MEDIUM Memory Not Limited /vitam-dev.yml: 4
MEDIUM Memory Not Limited /mongo_cluster.yml: 4
MEDIUM Memory Not Limited /docker-compose.yml: 27
MEDIUM Memory Not Limited /docker-compose.yml: 4
MEDIUM Memory Not Limited /docker-compose.yml: 4
MEDIUM Memory Not Limited /mongo_dev.yml: 4
MEDIUM Networks Not Set /vitam-dev.yml: 4
MEDIUM Networks Not Set /docker-compose.yml: 4
MEDIUM Networks Not Set /docker-compose.yml: 3
MEDIUM Networks Not Set /docker-compose.yml: 4
MEDIUM Networks Not Set /docker-compose.yml: 41
MEDIUM Networks Not Set /jaeger-docker-compose.yml: 3
MEDIUM Networks Not Set /docker-compose.yml: 4
MEDIUM Privileged Ports Mapped In Container /vitam-recette.yml: 21
MEDIUM Privileged Ports Mapped In Container /vitam-dev.yml: 28
MEDIUM Security Opt Not Set /jaeger-docker-compose.yml: 3
MEDIUM Security Opt Not Set /docker-compose.yml: 4
MEDIUM Security Opt Not Set /mongo_cluster.yml: 27
MEDIUM Security Opt Not Set /docker-compose.yml: 3
MEDIUM Security Opt Not Set /mongo_dev.yml: 4
MEDIUM Security Opt Not Set /docker-compose.yml: 4
MEDIUM Security Opt Not Set /docker-compose.yml: 41
MEDIUM Security Opt Not Set /mongo_dev.yml: 25
MEDIUM Security Opt Not Set /docker-compose.yml: 49
MEDIUM Security Opt Not Set /mongo_cluster.yml: 49
MEDIUM Security Opt Not Set /docker-compose.yml: 27
MEDIUM Security Opt Not Set /docker-compose.yml: 17
MEDIUM Security Opt Not Set /docker-compose.yml: 4
MEDIUM Security Opt Not Set /mongo_cluster.yml: 4
MEDIUM Shared Host Network Namespace /docker-compose.yml: 6
MEDIUM Shared Host Network Namespace /docker-compose.yml: 5
MEDIUM Shared Host Network Namespace /docker-compose.yml: 45
MEDIUM Update Instruction Alone /Dockerfile: 14
MEDIUM Update Instruction Alone /Dockerfile: 17
MEDIUM Update Instruction Alone /Dockerfile: 14
MEDIUM Yum Clean All Missing /Dockerfile: 39
MEDIUM Yum Clean All Missing /Dockerfile: 45
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 64
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 39
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 64
MEDIUM Yum install Without Version /Dockerfile: 77
MEDIUM Yum install Without Version /Dockerfile: 14
MEDIUM Yum install Without Version /Dockerfile: 45
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 64
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 69
MEDIUM Yum install Without Version /Dockerfile: 17
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 14
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 64
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 60
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 33
MEDIUM Yum install Without Version /Dockerfile: 64
LOW Container Capabilities Unrestricted /docker-compose.yml: 4
LOW Container Capabilities Unrestricted /docker-compose.yml: 49
LOW Container Capabilities Unrestricted /mongo_cluster.yml: 49
LOW Container Capabilities Unrestricted /mongo_cluster.yml: 27
LOW Container Capabilities Unrestricted /mongo_cluster.yml: 4
LOW Container Capabilities Unrestricted /mongo_dev.yml: 25
LOW Container Capabilities Unrestricted /docker-compose.yml: 4
LOW Container Capabilities Unrestricted /docker-compose.yml: 3
LOW Container Capabilities Unrestricted /docker-compose.yml: 27
LOW Container Capabilities Unrestricted /vitam-dev.yml: 4
LOW Container Capabilities Unrestricted /docker-compose.yml: 4
LOW Container Capabilities Unrestricted /docker-compose.yml: 17
LOW Container Capabilities Unrestricted /jaeger-docker-compose.yml: 3
LOW Container Capabilities Unrestricted /vitam-dev.yml: 17
LOW Container Capabilities Unrestricted /mongo_dev.yml: 4
LOW Container Capabilities Unrestricted /docker-compose.yml: 41
LOW Cpus Not Limited /docker-compose.yml: 4
LOW Cpus Not Limited /mongo_cluster.yml: 27
LOW Cpus Not Limited /docker-compose.yml: 49
LOW Cpus Not Limited /mongo_dev.yml: 25
LOW Cpus Not Limited /vitam-recette.yml: 41
LOW Cpus Not Limited /docker-compose.yml: 27
LOW Cpus Not Limited /mongo_cluster.yml: 49
LOW Cpus Not Limited /docker-compose.yml: 4
LOW Cpus Not Limited /docker-compose.yml: 17
LOW Cpus Not Limited /docker-compose.yml: 41
LOW Cpus Not Limited /mongo_cluster.yml: 4
LOW Cpus Not Limited /docker-compose.yml: 4
LOW Cpus Not Limited /jaeger-docker-compose.yml: 3
LOW Cpus Not Limited /docker-compose.yml: 4
LOW Cpus Not Limited /mongo_dev.yml: 4
LOW Cpus Not Limited /docker-compose.yml: 3
LOW Cpus Not Limited /vitam-dev.yml: 4
LOW Cpus Not Limited /vitam-recette.yml: 4
LOW Healthcheck Instruction Missing /Dockerfile: 10
LOW Healthcheck Instruction Missing /Dockerfile: 10
LOW Healthcheck Instruction Missing /Dockerfile: 10
LOW Healthcheck Instruction Missing /Dockerfile: 11
LOW Log_Forging /api/api-archive-search/archive-search-internal/src/main/java/fr/gouv/vitamui/archive/internal/server/rest/ArchiveSearchInternalController.java: 239
LOW Log_Forging /api/api-archive-search/archive-search-internal/src/main/java/fr/gouv/vitamui/archive/internal/server/rest/ArchiveSearchInternalController.java: 250
LOW MAINTAINER Instruction Being Used /Dockerfile: 11
LOW MAINTAINER Instruction Being Used /Dockerfile: 11
LOW MAINTAINER Instruction Being Used

More results are available on AST platform

@marob marob force-pushed the bug_12416_balises-avec-attribut-langues-non-affichees branch from 4ec9de1 to 16ded1a Compare March 27, 2024 17:39
@marob marob requested a review from Regzox March 28, 2024 09:07
@marob marob merged commit 471454e into develop Mar 29, 2024
2 checks passed
@marob marob deleted the bug_12416_balises-avec-attribut-langues-non-affichees branch March 29, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Regzox Regzox Regzox approved these changes

@soukami soukami soukami approved these changes

Assignees
No one assigned
Labels
bug Something isn't working java Pull requests that update Java code javascript Pull requests that update Javascript code VAS VAS contribution
Projects
None yet
Milestone
IT 133
Development

Successfully merging this pull request may close these issues.
4 participants
@marob @vitam-devops @Regzox @soukami