story #13140 : new datepicker component for design system #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regzox
approved these changes
Aug 1, 2024
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
...pp/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.html
Outdated
Show resolved
Hide resolved
marob
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Si le datepicker est disabled, on ne devrait pas pouvoir avoir de focus
Il manque un effet "hover" sur la sélection des années/mois/jour
Le composant ne gère pas le cas "required".
Si on saisit une valeur incorrecte, le label et la valeur s'affichent l'une sur l'autre (et aucune erreur ne s'affiche) :
ui/ui-frontend/projects/vitamui-library/src/app/modules/theme.service.ts
Outdated
Show resolved
Hide resolved
ui/ui-frontend/projects/vitamui-library/src/sass/mixins/_fonts.scss
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
...pp/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.html
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
...pp/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.scss
Show resolved
Hide resolved
...pp/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.scss
Outdated
Show resolved
Hide resolved
ui/ui-frontend/projects/design-system/src/app/components/inputs/inputs.component.html
Outdated
Show resolved
Hide resolved
hazco75
force-pushed
the
story_13140_new_datepicker
branch
from
d1116ef to
0cf74ea
Compare
marob
requested changes
Aug 12, 2024
There was a problem hiding this comment.
La date saisie n'est pas reflétée (saisie : 2021, en surbrillance : 2024)
Il est possible de basculer sur un écran de saisie de jour en cliquant sur l'année, même lorsque le datepicker est configuré pour saisir seulement une année ou année/mois
En navigation au clavier, il n'y a pas de surbrillance des années/mois/jours sur lesquels on a le "focus".
Un clic sur le mat-hint ne devrait pas focus le champ.
Le curseur de la souris n'est pas le même en hover sur l'input et sur "Date" ou les bords du champ. Il faudrait que ce soit un cursor: text partout.
...pp/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.html
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
.../app/modules/components/multiple-options-datepicker/multiple-options-datepicker.component.ts
Outdated
Show resolved
Hide resolved
12 tasks
hazco75
force-pushed
the
story_13140_new_datepicker
branch
from
0cf74ea to
4aeb9d4
Compare
marob
approved these changes
Aug 13, 2024
hazco75
force-pushed
the
story_13140_new_datepicker
branch
from
932851c to
4b12593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nouveau composant datepicker pour l'instant destiné pour le design-system
Type de changement
Indiquer le ou les types de changements
Contributeur