Bug #14108 [Collection] - [Issues with Adding Directory to a Deposit Project] #2414
+195
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salimdev
force-pushed
the
bug_14108
branch
3 times, most recently
from
328fa11 to
2f05a8d
Compare
marob
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Si on sélectionne un dossier puis le supprime, le bouton "Suivant" n'est pas grisé.
Il y a un refactoring global à prévoir. Un FileSelector ne devrait pas avoir un zip en input. D'ailleurs, il ne devrait peut-être pas gérer de zip tout court. En tout cas, il doit pouvoir fonctionner sans zip (usages autres que pour collecte).
Il faut écrire des tests unitaires.
...rontend/projects/collect/src/app/collect/projects/create-project/create-project.component.ts
Outdated
Show resolved
Hide resolved
ui/ui-frontend/projects/vitamui-library/src/lib/models/zip/zip-file.class.ts
Outdated
Show resolved
Hide resolved
ui/ui-frontend/projects/vitamui-library/src/lib/models/zip/zip-file.class.ts
Outdated
Show resolved
Hide resolved
...ojects/vitamui-library/src/app/modules/components/file-selector/file-selector.component.html
Outdated
Show resolved
Hide resolved
...cts/vitamui-library/src/app/modules/components/file-selector/file-selector.component.spec.ts
Show resolved
Hide resolved
...projects/vitamui-library/src/app/modules/components/file-selector/file-selector.component.ts
Outdated
Show resolved
Hide resolved
...projects/vitamui-library/src/app/modules/components/file-selector/file-selector.component.ts
Outdated
Show resolved
Hide resolved
...end/projects/collect/src/app/collect/archive-search-collect/add-units/add-units.component.ts
Outdated
Show resolved
Hide resolved
Salimdev
force-pushed
the
bug_14108
branch
2 times, most recently
from
48eb3c0 to
015173c
Compare
marob
requested changes
Jan 29, 2025
...end/projects/collect/src/app/collect/archive-search-collect/add-units/add-units.component.ts
Outdated
Show resolved
Hide resolved
...rontend/projects/collect/src/app/collect/projects/create-project/create-project.component.ts
Outdated
Show resolved
Hide resolved
...projects/vitamui-library/src/app/modules/components/file-selector/file-selector.component.ts
Outdated
Show resolved
Hide resolved
...projects/vitamui-library/src/app/modules/components/file-selector/file-selector.component.ts
Outdated
Show resolved
Hide resolved
ui/ui-frontend/projects/vitamui-library/src/lib/models/zip/zip-file.class.ts
Outdated
Show resolved
Hide resolved
...cts/vitamui-library/src/app/modules/components/file-selector/file-selector.component.spec.ts
Outdated
Show resolved
Hide resolved
...cts/vitamui-library/src/app/modules/components/file-selector/file-selector.component.spec.ts
Outdated
Show resolved
Hide resolved
...cts/vitamui-library/src/app/modules/components/file-selector/file-selector.component.spec.ts
Outdated
Show resolved
Hide resolved
...cts/vitamui-library/src/app/modules/components/file-selector/file-selector.component.spec.ts
Outdated
Show resolved
Hide resolved
hazco75
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs (Incorrect size: When uploading a directory from the file explorer, the displayed size is 0 bytes, Data loss: Several pieces of data are lost after validation.)
In drag & drop and with upload files/directories, handling empty folders (If the empty folder is located inside another parent directory, an error message will be displayed).