Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 1202 bump to minimum NodeJS 20.x version of 20.18.3 #1416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 10, 2025

Related Issue

#1202

Documentation

N / A

Summary of Changes

  1. Node 20.18.3 was released which marks JSON Import Attributes as stable (we use JSON modules in walker-package-ranger.js)

    [030f155986] - esm: mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333

Note: this overlaps with #1401 , but made it its own PR since it touches a different version range, and is also a breaking change

TODO

  1. Looks like we need to wait for GitHub Actions to catch up
    error @greenwood/cli@0.31.0: The engine "node" is incompatible with this module. Expected version "^18.20.5 || ^20.18.3 || ^22.12.0". Got "20.18.2"
    error Found incompatible module.

@thescientist13 thescientist13 added this to the 1.0 milestone Feb 10, 2025
@thescientist13 thescientist13 self-assigned this Feb 10, 2025
@thescientist13 thescientist13 changed the title bump to minimum NodeJS 20.x version of 20.18.3 enhancement/issue 1202 bump to minimum NodeJS 20.x version of 20.18.3 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant