Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: was monitoring incorrect event name for msa.MsaRetired #650

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: was monitoring incorrect event name for msa.MsaRetired #650

merged 3 commits into from
Oct 24, 2024

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented Oct 23, 2024 •
edited
Loading

  • Update correct event name for monitoring the retireMsa extrinsic from msa.retireMsa => msa.MsaRetired
  • Update log message when encountering a watched transaction in a block, but not the anticipated event, to be more informative.
  • Update webhook-server/Cargo.lock so VSCode rust-analyzer extension will stop trying to modify it

Closes #636

@JoeCap08055 JoeCap08055 requested a review from aramikm October 23, 2024 18:22
mattheworris
mattheworris approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, ship it!

@JoeCap08055 JoeCap08055 enabled auto-merge (squash) October 24, 2024 01:16
@JoeCap08055 JoeCap08055 merged commit e34124c into main Oct 24, 2024
15 checks passed
@JoeCap08055 JoeCap08055 deleted the fix/wrong-success-event-for-retireMsa branch October 24, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramikm aramikm aramikm approved these changes

@mattheworris mattheworris mattheworris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the bug where the worker can not find the desired event
3 participants
@JoeCap08055 @mattheworris @aramikm