Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: was monitoring incorrect event name for msa.MsaRetired #650

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: was monitoring incorrect event name for msa.MsaRetired #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83d3f2b
fix: was monitoring incorrect event name for msa.MsaRetired
JoeCap08055 Oct 23, 2024
1075371
fix: update Cargo.lock for webhook-server so VSCode extension won't k…
JoeCap08055 Oct 23, 2024
403f5e5
Merge branch 'main' into fix/wrong-success-event-for-retireMsa
JoeCap08055 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/account-worker/src/transaction_notifier/notifier.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ export class TxnNotifierService
}
}
} else {
this.logger.error(`Watched transaction ${txHash} found, but neither success nor error???`);
this.logger.error(
`Watched transaction ${txHash} found in block ${currentBlockNumber}, but did not find event '${txStatus.successEvent.section}.${txStatus.successEvent.method}' in block`,
);
}

pipeline = pipeline.hdel(TXN_WATCH_LIST_KEY, txHash); // Remove txn from watch list
Expand Down
4 changes: 2 additions & 2 deletions apps/account-worker/src/transaction_publisher/publisher.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,12 @@ export class TransactionPublisherService extends BaseConsumer implements OnAppli
}
case TransactionType.RETIRE_MSA: {
const trx = this.blockchainService.decodeTransaction(job.data.encodedExtrinsic);
targetEvent = { section: 'msa', method: 'retireMsa' };
targetEvent = { section: 'msa', method: 'MsaRetired' };
[tx, txHash] = await this.processProxyTxn(trx, job.data.accountId, job.data.signature);
break;
}
case TransactionType.REVOKE_DELEGATION: {
const trx = await this.blockchainService.decodeTransaction(job.data.encodedExtrinsic);
const trx = this.blockchainService.decodeTransaction(job.data.encodedExtrinsic);
targetEvent = { section: 'msa', method: 'DelegationRevoked' };
[tx, txHash] = await this.processProxyTxn(trx, job.data.accountId, job.data.signature);
this.logger.debug(`tx: ${tx}`);
Expand Down
4 changes: 3 additions & 1 deletion apps/graph-worker/src/graph_notifier/graph.monitor.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ export class GraphMonitorService extends BlockchainScannerService {
this.logger.verbose(`Successfully found transaction ${txHash} in block ${currentBlockNumber}`);
statusesToReport.push({ ...txStatus, status: 'succeeded' });
} else {
this.logger.error(`Watched transaction ${txHash} found, but neither success nor error???`);
this.logger.error(
`Watched transaction ${txHash} found in block ${currentBlockNumber}, but did not find event '${txStatus.successEvent.section}.${txStatus.successEvent.method}' in block`,
);
}

pipeline = pipeline.hdel(TXN_WATCH_LIST_KEY, txHash); // Remove txn from watch list
Expand Down
Loading